Repository navigation
release: 1.39.0 - #398
release: 1.39.0#398openai-sdks[bot] wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: ✅ No new custom-code files detected. 5 mixed files remain; 0 existing customizations changed. Compared 5 existing customizations unchanged
A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 38326718287 --repo openai/openai-cli \
--name castiron-custom-code-38326718287-1 --dir /tmp/castiron-custom-code-38326718287-1
git apply --stat /tmp/castiron-custom-code-38326718287-1/custom-code.patch
cat /tmp/castiron-custom-code-38326718287-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 673c5ebab5ed5f2c51d954b75983121be25e2d16 f1b13f71371e5958c20f2e2b98f6d9b312c9e2f4
python3 scripts/castiron/custom_code_report.py report \
--base 673c5ebab5ed5f2c51d954b75983121be25e2d16 \
--head f1b13f71371e5958c20f2e2b98f6d9b312c9e2f4 --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-f1b13f71371e
cat /tmp/castiron-custom-code-f1b13f71371e/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22078e8678
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ### Chores | ||
|
|
||
| * **deps:** update openai-go to v3.74.0 ([#393](https://github.com/openai/openai-cli/issues/393)) ([e32158e](https://github.com/openai/openai-cli/commit/e32158e57f05eae260ebb7a0bd0cacc6b2961ce1)) |
There was a problem hiding this comment.
When this release is tagged, the v1.38.0...v1.38.1 range also includes 6fcc478 (the complete-help behavior change) and 86502b0 (new models list --filter and --sort-by functionality), but this changelog lists only the SDK dependency update. Consequently, observable CLI features are shipped as an undocumented patch release; include those entries and regenerate this as the appropriate minor release rather than publishing a dependency-only 1.38.1 changelog.
Useful? React with 👍 / 👎.
|
[saibot] review pending. full review is queued or incomplete. no approval yet. |
jbeckwith-oai
left a comment
jbeckwith-oai
left a comment
There was a problem hiding this comment.
Confirmed the existing release-note finding at #398 (comment) against the actual v1.38.0..e32158e history: this release also contains the complete-help changes (#384), list navigation/tables (#389/#390), and model filtering/sorting (#391), but its changelog describes only the SDK bump. Please include the shipped user-facing changes and reconcile the release version before publishing. Keeping the discussion on the existing finding rather than duplicating an inline comment.
The manifest and CLI version agree at 1.38.1, and the current hosted checks pass (conditional jobs skipped). This review covers release metadata and the included commit range; it does not re-review the already merged feature implementations.
22078e8 to
4f40a98
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4f40a986e9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,5 +1,13 @@ | |||
| # Changelog | |||
|
|
|||
| ## [1.38.1](https://github.com/openai/openai-cli/compare/v1.38.0...v1.38.1) (2026-10-09) | |||
There was a problem hiding this comment.
The v1.38.0...v1.38.1 range now contains additional user-facing changes beyond those covered by the earlier review comment: 217ff2e adds the tokenizer and codex commands, 866d877 adds global --quiet/--verbose controls, e689398 adds file routes and positional uploads, and 390a9c3 changes streaming, stdin, and download behavior. Publishing this range as a dependency-only patch leaves major commands, flags, and fixes undocumented and assigns a patch version to feature additions; regenerate it as the next minor release with entries for all observable changes.
Useful? React with 👍 / 👎.
c684a70 to
a307283
Compare
a307283 to
03bd39f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03bd39f181
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,5 +1,35 @@ | |||
| # Changelog | |||
|
|
|||
| ## [1.39.0](https://github.com/openai/openai-cli/compare/v1.38.0...v1.39.0) (2026-10-12) | |||
There was a problem hiding this comment.
Fresh evidence since the earlier review is that the advertised v1.38.0...v1.39.0 range now also contains 4183995, which adds the user-facing openai setup admin command and admin-key guidance, yet the regenerated section has no entry for it and still omits the previously noted tokenizer, file-workflow, output-control, and help changes. Tagging this commit would therefore publish a materially incomplete changelog; add the missing release entries before tagging.
Useful? React with 👍 / 👎.
03bd39f to
a85bd58
Compare
a85bd58 to
f1b13f7
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f1b13f7137
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ### Bug Fixes | ||
|
|
||
| * **autocomplete:** preserve colon argument boundaries ([#413](https://github.com/openai/openai-cli/issues/413)) ([5739ce0](https://github.com/openai/openai-cli/commit/5739ce0f3a6cc5887092554a403bf53357eca9a4)) | ||
| * **autocomplete:** preserve quoted Bash command prefixes ([#399](https://github.com/openai/openai-cli/issues/399)) ([c3c66c4](https://github.com/openai/openai-cli/commit/c3c66c4c014e7759a6f3b61a595d1c54fd542db9)) |
There was a problem hiding this comment.
Fresh evidence beyond the existing review threads is that this commit's first parent now includes #439 (e8ffaab, resumed-stream and empty-API-error fixes), #440 (47d6a16, help values and Bash file completion), and #441 (673c5eb, Models SIGINT shutdown), all after the previously cited #387 change, but this section contains none of them. Tagging this commit therefore ships three additional user-visible fixes in the advertised v1.38.0...v1.39.0 range without release notes; add entries for these newly included fixes before release.
Useful? React with 👍 / 👎.
This branch has not been deployed
2 participants
Automated Release PR
1.39.0 (2026-10-13)
Features
Bug Fixes
Chores
This PR was generated with Release Please. See documentation.