-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(voice): accept string TTS dtypes #4797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
harshitethic
wants to merge
4
commits into
openai:main
Choose a base branch
from
harshitethic:fix/voice-dtype-settings-final
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+57
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dfea18d
fix: normalize TTS dtype configuration
harshitethic a4fdfa1
fix(voice): preserve dtype error contract
harshitethic 733d194
test(voice): cover configured TTS dtype behavior
harshitethic 29d5446
style(voice): restore TTS settings documentation
harshitethic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import numpy as np | ||
| import pytest | ||
|
|
||
| from agents.exceptions import UserError | ||
| from agents.voice import AudioInput, TTSModelSettings, VoicePipeline | ||
|
|
||
| from .helpers import extract_events | ||
| from .pipeline_test_models import QueuedSTTModel, QueuedVoiceWorkflow, ZeroPcmTTSModel | ||
|
|
||
|
|
||
| @pytest.mark.asyncio | ||
| @pytest.mark.parametrize( | ||
| ("dtype", "expected_dtype"), | ||
| [("int16", np.int16), ("float32", np.float32), ("f4", np.float32)], | ||
| ids=["int16-string", "float32-string", "float32-alias"], | ||
| ) | ||
| async def test_voicepipeline_accepts_string_tts_dtype_from_dictionary_config( | ||
| dtype: str, | ||
| expected_dtype: type[np.int16] | type[np.float32], | ||
| ) -> None: | ||
| fake_stt = QueuedSTTModel(["first"]) | ||
| fake_tts = ZeroPcmTTSModel() | ||
| pipeline = VoicePipeline( | ||
| workflow=QueuedVoiceWorkflow([["out_1"]]), | ||
| stt_model=fake_stt, | ||
| tts_model=fake_tts, | ||
| config={"tts_settings": {"buffer_size": 1, "dtype": dtype}}, | ||
| ) | ||
|
|
||
| result = await pipeline.run(AudioInput(buffer=np.zeros(2, dtype=np.int16))) | ||
| events, audio_chunks = await extract_events(result) | ||
|
|
||
| assert events == ["turn_started", "audio", "turn_ended", "session_ended"] | ||
| decoded_audio = np.frombuffer(audio_chunks[0], dtype=expected_dtype) | ||
| assert decoded_audio.dtype == np.dtype(expected_dtype) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| "dtype", | ||
| ["not-a-dtype", {"names": ["x"], "formats": []}], | ||
| ids=["unparseable-string", "malformed-structured-dtype"], | ||
| ) | ||
| def test_tts_model_settings_preserves_user_error_for_invalid_dtype(dtype: object) -> None: | ||
| with pytest.raises(UserError, match="Invalid output dtype"): | ||
| TTSModelSettings(dtype=dtype) # type: ignore[arg-type] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Importing
agents.voicenow fails before any voice API can be used: its__init__imports.model, butagents.voice.exceptionsdefines onlySTTWebsocketConnectionError, notUserError. Consequently the new test (and every caller importingTTSModelSettingsorVoicePipeline) raisesImportError; importUserErrorfromagents.exceptionsvia..exceptionsinstead.AGENTS.md reference: AGENTS.md:L147-L147
Useful? React with 👍 / 👎.