fix(voice): accept string dtype settings - #4794
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Closing in favor of #4778, which predates this PR and covers the same dtype normalization behavior with broader regression coverage. Thanks to @ErenAta16 for the careful side-by-side comparison. |
Summary
UserError("Invalid output dtype")for unsupported or invalid dtypesFixes #4777
Validation
.venv/bin/pytest -q tests/voice/test_pipeline.py(58 passed).venv/bin/ruff check src/agents/voice/result.py tests/voice/test_pipeline.py.venv/bin/ruff format --check src/agents/voice/result.py tests/voice/test_pipeline.py.venv/bin/pyright --project pyrightconfig.json src/agents/voice/result.py tests/voice/test_pipeline.pygit diff --check