Skip to content

feat(cli): add optional patch-risk assessment to deterministic reviews - #629

Draft
tdullien1 wants to merge 2 commits into
codex/deterministic-core-patch-reviewsfrom
codex/deterministic-patch-risk-assessment
Draft

feat(cli): add optional patch-risk assessment to deterministic reviews#629
tdullien1 wants to merge 2 commits into
codex/deterministic-core-patch-reviewsfrom
codex/deterministic-patch-risk-assessment

Conversation

@tdullien1

Copy link
Copy Markdown
Collaborator

Summary

Add optional patch-risk assessment as a separately reviewable extension to the deterministic minimality and coding-style review workflow.

Changes

  • Add opt-in --assess-patch-risk support to both patching entry points and run assessment after the selected minimality and style stages.
  • Require structured reviewer status, a merge recommendation, and a concise Markdown assessment; fail closed on blocked, malformed, or inconsistent verdicts.
  • Restart earlier review stages after an actionable risk-assessment revision when an explicit revision budget allows it.
  • Bundle the assessment skill, risk rubric, boundary-challenge reference, optional machine-readable assessment schema, and artifact-validation utilities.
  • Support deterministic patch materialization in sparse checkouts.
  • Preserve the deterministic-core test cases while adding risk-stage ordering, revision, verdict, and publication-safety coverage.
  • The optional JSON Schema is 3,533 lines and is deliberately isolated here for an independent maintainability and necessity review; the normal CLI review contract does not require the schema.

Testing

  • bun test --timeout 30000 tests-ts/cli-skills.test.ts tests-ts/cli-patch.test.ts — 66 tests passed.
  • node scripts/generate-models.cjs --check — passed.
  • node node_modules/typescript/bin/tsc --noEmit — passed.
  • node node_modules/prettier/bin/prettier.cjs --check --ignore-path .gitignore --ignore-path .prettierignore '**/*.{cjs,mjs,js,ts,tsx,json,md}' — passed.
  • JSON Schema Draft 2020-12 structural validation and Python syntax checks for both risk-assessment utilities — passed.

Risk and rollout

Risk assessment is opt-in and disabled by default. Its reviewer runs read-only and cannot apply or merge patches. The public flag, bundled skill assets, optional schema, and Python helper requirements are isolated from the deterministic-review base so they can be reviewed, simplified, or rejected independently.

Public disclosure review

  • No customer, partner, prospect, or user identities, data, or identifying details are included.
  • No credentials, personal data, private source, scan findings, or nonpublic links or tickets are included.
  • I reviewed the branch name, title, description, commits, changes, comments, logs, screenshots, attachments, and links for public disclosure.

@tdullien1
tdullien1 force-pushed the codex/deterministic-patch-risk-assessment branch 3 times, most recently from 515972a to 2385874 Compare August 24, 2026 10:04
@tdullien1
tdullien1 force-pushed the codex/deterministic-patch-risk-assessment branch from 2385874 to caae917 Compare August 24, 2026 12:26
@tdullien1 tdullien1 changed the title Add optional patch-risk assessment to deterministic reviews feat(cli): add optional patch-risk assessment to deterministic reviews Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant