Conversation
waitForBrokerEndpoint only resolved on connect or error, so a named pipe or Unix socket that never completed left ensureBrokerSession and later commands hung past their readiness budget. Time out each connect attempt, apply the same deadline when opening a broker client, and treat ETIMEDOUT like the other connection failures that already fall back to a direct app-server.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
waitForBrokerEndpointonly resolved when a socket connected or errored. A named pipe or Unix socket that stayed in connecting state never tripped the 150ms/2s readiness budget, soensureBrokerSessionand later companion commands could hang indefinitely. Broker clientinitialize()had the same gap, and a timed-out connect was not retried on a direct app-server the wayENOENT/ECONNREFUSEDalready are.Change
ETIMEDOUT.ETIMEDOUTas a retryable broker connection failure inwithAppServer.Test
waitForBrokerEndpoint returns false when connect hangs past the timeouthangs until the test runner timeout on main and passes after this change.AI-assisted (Grok)