Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion plugins/codex/scripts/codex-companion.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,11 @@ async function executeReviewRun(request) {
stderr: result.stderr,
stdout: result.reviewText,
reasoning: result.reasoningSummary
}
},
result: null,
rawOutput: result.reviewText,
parseError: "The built-in reviewer returns prose; use adversarial-review for structured output.",
reasoningSummary: result.reasoningSummary
};
const rendered = renderNativeReviewResult(
{
Expand Down
17 changes: 17 additions & 0 deletions tests/runtime.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,23 @@ test("review renders a no-findings result from app-server review/start", () => {
assert.match(result.stdout, /No material issues found/);
});

test("review --json explicitly reports that native review output is unstructured", () => {
const repo = makeTempDir();
const binDir = makeTempDir();
installFakeCodex(binDir);
initGitRepo(repo);
fs.writeFileSync(path.join(repo, "README.md"), "hello\n");
run("git", ["add", "README.md"], { cwd: repo });
run("git", ["commit", "-m", "init"], { cwd: repo });
fs.writeFileSync(path.join(repo, "README.md"), "hello again\n");
const result = run("node", [SCRIPT, "review", "--json"], { cwd: repo, env: buildEnv(binDir) });
assert.equal(result.status, 0, result.stderr);
const payload = JSON.parse(result.stdout);
assert.equal(payload.result, null);
assert.equal(payload.rawOutput, payload.codex.stdout);
assert.match(payload.parseError, /built-in reviewer.*prose.*adversarial-review/i);
});

test("task runs when the active provider does not require OpenAI login", () => {
const repo = makeTempDir();
const binDir = makeTempDir();
Expand Down