Skip to content

fix(status): avoid HTML breaks in action cells #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tianrking wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −2
Open

fix(status): avoid HTML breaks in action cells #511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/codex/scripts/lib/render.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ function appendActiveJobsTable(lines, jobs) {
actions.push(`/codex:cancel ${job.id}`);
}
lines.push(
`| ${escapeMarkdownCell(job.id)} | ${escapeMarkdownCell(job.kindLabel)} | ${escapeMarkdownCell(job.status)} | ${escapeMarkdownCell(job.phase ?? "")} | ${escapeMarkdownCell(job.elapsed ?? "")} | ${escapeMarkdownCell(job.threadId ?? "")} | ${escapeMarkdownCell(job.summary ?? "")} | ${actions.map((action) => `\`${action}\``).join("<br>")} |`
`| ${escapeMarkdownCell(job.id)} | ${escapeMarkdownCell(job.kindLabel)} | ${escapeMarkdownCell(job.status)} | ${escapeMarkdownCell(job.phase ?? "")} | ${escapeMarkdownCell(job.elapsed ?? "")} | ${escapeMarkdownCell(job.threadId ?? "")} | ${escapeMarkdownCell(job.summary ?? "")} | ${actions.map((action) => `\`${action}\``).join("; ")} |`
);
}
}
Expand Down
3 changes: 2 additions & 1 deletion tests/runtime.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,7 +1145,8 @@ test("status shows phases, hints, and the latest finished job", () => {
assert.match(result.stdout, /Active jobs:/);
assert.match(result.stdout, /\| Job \| Kind \| Status \| Phase \| Elapsed \| Codex Session ID \| Summary \| Actions \|/);
assert.match(result.stdout, /\| review-live \| review \| running \| reviewing \| .* \| thr_1 \| Review working tree diff \|/);
assert.match(result.stdout, /`\/codex:status review-live`<br>`\/codex:cancel review-live`/);
assert.match(result.stdout, /`\/codex:status review-live`; `\/codex:cancel review-live`/);
assert.doesNotMatch(result.stdout, /<br>/);
assert.match(result.stdout, /Live details:/);
assert.match(result.stdout, /Latest finished:/);
assert.match(result.stdout, /Progress:/);
Expand Down