Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a workflow task is appended,
AgentContext.add_workflow_taskand the reasoning-summarydonehandler instream_agent_responsecomputetask_indexwithworkflow.tasks.index(task). Tasks are Pydantic models compared by value, so a task equal to an earlier one gets the earlier task's index. The second task is stored at position 1, but itsWorkflowTaskAddedevent saystask_index=0.Use
len(tasks) - 1immediately after the append, which is where the task was actually stored. Indices for distinct tasks are unchanged.Tests
mypy .stops at the same duplicate-module discovery error fortests/_types.pyon both base and this branch; no Mypy pass is claimed.Scope
This fixes the index in the emitted
WorkflowTaskAddedevent. No browser or live model API run was performed. Index lookups for task updates are unchanged.