Repository navigation
fix: retain widget text updates without component IDs - #132
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appending text to a Text or Markdown component without an ID produces no widget update: the diff treats it as streamable, but delta collection requires an ID and silently drops the change.
Require an ID before taking the streaming-text path, so unidentified components trigger the existing root replacement behavior. Add regressions for typed and dynamic Text/Markdown components, including empty IDs. Identified text continues to use streaming deltas.
Validation: the initial two regression tests fail before the fix. All 136 tests pass afterward; the full Ruff and Pyright checks pass.