Skip to content

Remove ts-ignore for single measurement body - #1038

Merged
jona159 merged 2 commits into
devfrom
fix/send-measurement-types
Jul 22, 2026
Merged

Remove ts-ignore for single measurement body#1038
jona159 merged 2 commits into
devfrom
fix/send-measurement-types

Conversation

@scheidtdav

Copy link
Copy Markdown
Member

Type of Change

  • Dependency upgrade
  • Bug fix (non-breaking change)
  • Breaking change
    • e.g. a fixed bug or new feature that may break something else
  • New feature
  • Code quality improvements
    • e.g. refactoring, documentation, tests, tooling, ...

Implementation

I added a transform to the LongitudeLatitudeLocationObjectSchema such that compatible types fall out of the schema for the SingleMeasurementBody in order to get rid of the ts-ignore.

Checklist

  • I gave this pull request a meaningful title
  • My pull request is targeting the dev branch
  • I have added documentation to my code
  • I have deleted code that I have commented out

Additional Information

  • This PR closes #

@scheidtdav
scheidtdav requested a review from jona159 July 22, 2026 08:38
@github-actions

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 67.33% 2202 / 3270
🔵 Statements 65.81% 2272 / 3452
🔵 Functions 65.09% 427 / 656
🔵 Branches 51.47% 1049 / 2038
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
app/lib/openapi/schemas/location.ts 88.88% 50% 100% 87.5% 61-65
app/lib/openapi/schemas/measurement.ts 100% 100% 100% 100%
app/routes/api.boxes.$deviceId.$sensorId.ts 73.21% 50% 100% 73.21% 155-157, 165, 171-173, 189-190, 198-199, 209-210, 247-248, 261-268
app/services/measurement-service.server.ts 68.75% 65.93% 100% 70.96% 34, 53, 90, 93, 110, 131, 133, 137, 142, 149-151, 163-165, 182-184, 198-200, 206-208, 229-231, 317-324, 332-341
Generated in workflow #2800 for commit 6bfa644 by the Vitest Coverage Report Action

@jona159
jona159 merged commit d18cee4 into dev Jul 22, 2026
6 checks passed
@jona159
jona159 deleted the fix/send-measurement-types branch July 22, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants