Skip to content

ci(release-please): bump action to v5.0.0-oce.3 - #28

Merged
kojiromike merged 1 commit into
mainfrom
kojiromike/bump-release-please-action-oce3
Sep 2, 2026
Merged

ci(release-please): bump action to v5.0.0-oce.3#28
kojiromike merged 1 commit into
mainfrom
kojiromike/bump-release-please-action-oce3

Conversation

@kojiromike

Copy link
Copy Markdown
Contributor

Draft — blocked. The v5.0.0-oce.3 tag does not exist yet. Merging this before the tag is pushed breaks release-please for every consumer of the reusable workflow. See "Blocked on" below.

v5.0.0-oce.3 will be the first release-please-action tag whose bundled dist/index.js actually defaults annotatedTag to true.

The library change (openCoreEMR/release-please#4) merged some time ago, but release-please-action pins the library by branch in package.json while package-lock.json pins a commit, and every build path uses npm ci. The branch pin therefore behaved as a SHA pin: v5.0.0-oce.2 still ships the lightweight-tag behavior. openCoreEMR/release-please-action#2 moves the lockfile and rebuilds dist/.

#25 already updated this repo's README and the workflow header to say annotated tags are the default. That claim becomes true only with this bump. The README carried the same hardcoded ref, so it moves here too.

Blocked on

  1. chore: rebuild dist with annotated tags on by default release-please-action#2 merging into rebase/v5.
  2. The v5.0.0-oce.3 annotated + signed tag being cut from origin/rebase/v5 and its GitHub release published.

Mark ready for review once the tag exists.

Downstream

Most org repos reach the action through this reusable workflow, pinned at @1.0.0, so they pick the bump up via Dependabot once this merges and a new github-workflows-public release is cut. Four repos call the action directly and need their own Dependabot bumps: public-website (oce.1), oce-api-harness (oce.1), oce-authz-policies (oce.1), github-workflows-internal (oce.2).

v5.0.0-oce.3 is the first release-please-action tag whose bundled
dist/index.js actually defaults annotatedTag to true. The library change
merged earlier, but the action's package-lock.json pinned the old
library commit and every build path uses npm ci, so oce.2 still shipped
the lightweight-tag behavior.

The workflow header and README already describe annotated tags as the
default; this bump is what makes that claim true. README carried the
same hardcoded ref and moves with it.

Assisted-by: Claude Code
@kojiromike
kojiromike marked this pull request as ready for review September 1, 2026 21:49
@kojiromike
kojiromike merged commit 1b7ac85 into main Sep 2, 2026
1 check passed
@kojiromike
kojiromike deleted the kojiromike/bump-release-please-action-oce3 branch September 2, 2026 01:00
kojiromike added a commit that referenced this pull request Sep 2, 2026
Tag 1.0.1 was cut from a commit that predates the bump of
release-please-reusable.yml to release-please-action v5.0.0-oce.3
(#28), and that bump landed as a ci: commit, which this repo's
release-please config treats as hidden and non-releasing. Consumers
pinned at 1.0.x therefore still run the opt-in annotated-tag build.
Force a release so Dependabot can move them.

Release-As: 1.0.2

Assisted-by: Claude Code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant