fix: run actionlint from the OCE fork with corrected action metadata - #27
Merged
Conversation
Upstream actionlint v1.7.12 ships stale bundled metadata for `actions/create-github-app-token@v3`: it still marks `app-id` as required and does not know `client-id`, so every call site using the canonical (non-deprecated) input gets two false positives. Upstream's metadata-refresh workflow has been wedged since 2026-03 and the fixes (rhysd/actionlint#652, #668) are unmerged. Points the lint step at openCoreEMR/actionlint@v1.7.12-oce.1 — v1.7.12 plus the regenerated metadata entry. No published image is needed; GitHub builds the action from the fork's Dockerfile exactly as it does for upstream.
With actionlint no longer suppressing it, three call sites surfaced as using the deprecated `app-id` input. All were already passing a Client ID, so this is a key rename with no behaviour change. release-please-reusable.yml also carried a comment saying to stay on `app-id` until actionlint caught up; the OCE fork does, so it is gone. The reusable-workflow secret keeps the name `app-id` to avoid breaking pinned callers; only its description and the value it feeds change.
kojiromike
force-pushed
the
actionlint-oce-fork
branch
from
September 2, 2026 00:23
a951309 to
5b6422a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream actionlint v1.7.12 ships stale bundled metadata for
actions/create-github-app-token@v3: it still marksapp-idas required and does not knowclient-id, so every call site using the canonical input gets two false positives. Upstream's metadata-refresh workflow has been wedged since 2026-03 and the fixes (rhysd/actionlint#652, #668) are unmerged.Points the lint step at
openCoreEMR/actionlint@v1.7.12-oce.1— v1.7.12 plus the regenerated metadata entry. No published image is needed; GitHub builds the action from the fork's Dockerfile exactly as it does for upstream.With the metadata corrected, three follow-on cleanups fall out:
.github/actionlint.yaml. ci(release-please): pass the Client ID as client-id, not the deprecated app-id #26 added it to suppress those two messages forrelease-please-reusable.yml, with a comment saying to drop it once actionlint ships the renamed input. It does now.release-please-reusable.ymlthat explained the suppression.php-tests.yml/php-composer-script.ymlmove toclient-idtoo. ci(release-please): pass the Client ID as client-id, not the deprecated app-id #26 left these onapp-idon the grounds that their credential is a caller-supplied App ID rather than a Client ID. That turns out not to hold: callers passsecrets.OPENEMR_INTERNAL_CLIENT_IDinto theapp-idsecret, so the value was already a Client ID. The secret keeps its name to avoid breaking pinned callers; only its description and the input it feeds change.Verified with the fork under both shellcheck 0.10.0 (what GitHub runners ship) and 0.11.0: 0 findings. Control — upstream v1.7.12 with the suppression deleted — reports all six false positives.