Repository navigation
993 bug openapi job fails - #994
Merged
Merged
Conversation
calumbell
approved these changes
Oct 4, 2026
calumbell
left a comment
calumbell
left a comment
Contributor
There was a problem hiding this comment.
Alright looks good! Had a poke around on local, the generate_openapi_spec.sh script runs without error now. It also looks like the Github Action has successfully run.
I have tested the changes to the API with a local fork of the front-end and the removal of deprecated fields doesn't seem to have introduced any bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the openapi spec. Roughly, it was still on pipenv, and moving it to uv solved the major problem. Bonus though, the warnings (which would cause the spec gen to fail), are all fixed by a couple of type hints, some method removals(!), and some cleanup of fields which had been deprecated.