feat: Implement editable field components for scalar value types - #335
Open
kumaradityaraj wants to merge 5 commits into
Open
feat: Implement editable field components for scalar value types#335kumaradityaraj wants to merge 5 commits into
kumaradityaraj wants to merge 5 commits into
Conversation
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR enhances the side panel “Properties” rendering by introducing richer field typing in getTaskDetails and rendering those field types as appropriate UI controls (inputs, switches, textarea, combobox) instead of plain text.
Changes:
- Refactors
DetailFieldto include richerkindvariants (scalar/enum/runtime-expression/duration/long-string) and updates task flattening logic accordingly. - Updates the side panel property renderer to render per-kind controls (e.g., number input, switch, textarea, combobox).
- Updates and expands tests to reflect the new field model and verify rendering for number/boolean fields.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/open-workflow-diagram-editor/tests/side-panel/NodeDetailsView.test.tsx | Updates assertions to match input-based rendering and adds tests for number + boolean controls. |
| packages/open-workflow-diagram-editor/tests/core/taskDetails.test.ts | Updates expected DetailField shapes and adds tests for long-string/enum/duration classification. |
| packages/open-workflow-diagram-editor/src/side-panel/NodeDetailsView.tsx | Routes DetailField objects to PropertyField for typed rendering; propagates isReadOnly. |
| packages/open-workflow-diagram-editor/src/side-panel/Fields.tsx | Implements typed property rendering controls (textarea/input/switch/combobox) and duration validation. |
| packages/open-workflow-diagram-editor/src/core/taskDetails.ts | Expands DetailField and adds classification for long-string/runtime-expression/duration/enum fields. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
Signed-off-by: kumaradityaraj <sedulous.0007@gmail.com>
kumaradityaraj
requested review from
cheryl7114,
fantonangeli,
handreyrc and
lornakelly
August 18, 2026 14:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #295
Changes
Added
Inputfor string fields with focus-visible ring styling.Added auto-growing
Textareafor long string fields such as commands and scripts.Added
Inputwithtype="number"for number fields.Added
Switchfor boolean fields.Added
Comboboxfor enum fields.Added monospace
Inputwith hint text for runtime expression fields.Added
Inputwith ISO 8601 validation for duration fields.Added
isReadOnlysupport across all scalar field controls:disabledstate for accessibility.isReadOnlyis enabled.Screenshots