Fix copy-pasted log message in SpanContext.__delattr__#5439
Open
Eason09053360 wants to merge 2 commits into
Hidden character warning
The head ref may contain hidden characters: "improve\uff3fsetting_property"
Open
Fix copy-pasted log message in SpanContext.__delattr__#5439Eason09053360 wants to merge 2 commits into
Eason09053360 wants to merge 2 commits into
Conversation
The debug message logged when deleting an attribute said "ignoring call to set attribute", copied from __setattr__. Say "delete attribute" so the log matches the intercepted operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a copy-pasted log message in
SpanContext.__delattr__.This PR changes the message to "ignoring call to delete attribute" so
the log matches the intercepted operation. No behavior change.
Type of change
How Has This Been Tested?
no new tests were added. Verified existing test suite passes with
tox -e py312-test-opentelemetry-api.Does This PR Require a Contrib Repo Change?
Checklist: