Skip to content

Fix missing f-prefix in exponential histogram max_size error messages #5434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aabmass merged 3 commits into from
Jul 23, 2026
+3 −2
Merged

Fix missing f-prefix in exponential histogram max_size error messages #5434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40273eb
Fix missing f-prefix in exponential histogram max_size error messages
Eason09053360 Jul 18, 2026
cc89bd8
Add changelog fragment
Eason09053360 Jul 19, 2026
4c7c169
Merge branch 'main' into fix-fstring-prefix-exponential-histogram
emdneto Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/5434.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
`opentelemetry-sdk`: fix missing f-prefix in exponential histogram error messages
4 changes: 2 additions & 2 deletions opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/aggregation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,13 +644,13 @@ def __init__(
if max_size < self._min_max_size:
raise ValueError(
f"Buckets max size {max_size} is smaller than "
"minimum max size {self._min_max_size}"
f"minimum max size {self._min_max_size}"
)

if max_size > self._max_max_size:
raise ValueError(
f"Buckets max size {max_size} is larger than "
"maximum max size {self._max_max_size}"
f"maximum max size {self._max_max_size}"
)
if max_scale > 20:
_logger.warning(
Expand Down
Loading