Add timeout shutdown config to PeriodicMetricReader and its builder - #8756
Open
brunobat wants to merge 1 commit into
Open
Add timeout shutdown config to PeriodicMetricReader and its builder#8756brunobat wants to merge 1 commit into
brunobat wants to merge 1 commit into
Conversation
Contributor
|
brunobat
force-pushed
the
set-shutdown-timeout
branch
from
August 28, 2026 10:34
dc74967 to
64f3e8b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8756 +/- ##
============================================
- Coverage 91.29% 91.28% -0.01%
- Complexity 10498 10500 +2
============================================
Files 1006 1006
Lines 28338 28346 +8
Branches 3581 3582 +1
============================================
+ Hits 25870 25877 +7
Misses 1675 1675
- Partials 793 794 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Pull request dashboard statusWaiting on reviewers · refreshed 2026-09-02 14:35 UTC Review the latest changes. Status above doesn't look right?
|
jamezp
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using native instrumentation with the autoconfigure and custom executors we notice there is always a fixed 5s penalty on shutdown.
This causes unecessary delays on all tests instantiating metrics with a real PeriodicMeterReader and also ignores any timeout defined on the server side.
This PR exposes the value as a builder option while preserving the existing default.
The API change is just 2 new methods.