Skip to content

Align UCUM byte unit conversions with the specification table #8752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thswlsqls wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Open

Align UCUM byte unit conversions with the specification table #8752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .../prometheus/src/main/java/io/opentelemetry/exporter/prometheus/PrometheusUnitsHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ class PrometheusUnitsHelper {
initUnit("KiBy", "kibibytes", "kibibyte");
initUnit("MiBy", "mebibytes", "mebibyte");
initUnit("GiBy", "gibibytes", "gibibyte");
initUnit("TiBy", "tibibytes", "tibibyte");
initUnit("TiBy", "tebibytes", "tebibyte");
initUnit("kBy", "kilobytes", "kilobyte");
// Upper case K is kelvin in UCUM, but keep it as an alias for existing users.
initUnit("KBy", "kilobytes", "kilobyte");
initUnit("MBy", "megabytes", "megabyte");
initUnit("GBy", "gigabytes", "gigabyte");
Expand Down
3 changes: 2 additions & 1 deletion ...metheus/src/test/java/io/opentelemetry/exporter/prometheus/PrometheusUnitsHelperTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,14 @@ private static Stream<Arguments> providePrometheusOTelUnitEquivalentPairs() {
return Stream.of(
Arguments.argumentSet("bytes", "By", "bytes"),
Arguments.argumentSet("kilobytes", "KBy", "kilobytes"),
Arguments.argumentSet("kilobytes lowercase k", "kBy", "kilobytes"),
Arguments.argumentSet("megabytes", "MBy", "megabytes"),
Arguments.argumentSet("gigabytes", "GBy", "gigabytes"),
Arguments.argumentSet("terabytes", "TBy", "terabytes"),
Arguments.argumentSet("kibibytes", "KiBy", "kibibytes"),
Arguments.argumentSet("mebibytes", "MiBy", "mebibytes"),
Arguments.argumentSet("gibibytes", "GiBy", "gibibytes"),
Arguments.argumentSet("tibibytes", "TiBy", "tibibytes"),
Arguments.argumentSet("tebibytes", "TiBy", "tebibytes"),
Arguments.argumentSet("days", "d", "days"),
Arguments.argumentSet("hours", "h", "hours"),
Arguments.argumentSet("seconds", "s", "seconds"),
Expand Down
Loading