Fix stale Javadoc references in api/incubator#8615
Draft
thswlsqls wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8615 +/- ##
=========================================
Coverage 91.63% 91.63%
Complexity 10326 10326
=========================================
Files 1013 1013
Lines 27295 27295
Branches 3205 3205
=========================================
Hits 25011 25011
Misses 1558 1558
Partials 726 726 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8614
Description
Three public Javadoc comments in
:api:incubatorpoint at things that moved or no longer exist.InstrumentationConfigUtil.getOrNull(): drop "Returns null ifConfigProvider#getInstrumentationConfig()is null" — make getInstrumentationConfig non-null #7954 (a46b073) made that method non-null and deleted the null check, leaving the Javadoc behind. That return path cannot happen; the other two null conditions are real and stay.ConfigProvider.getInstrumentationConfig(): retarget the schema link fromschema/instrumentation.json(404) toschema/instrumentation.yaml— Yaml source of truth for JSON schema files opentelemetry-configuration#411 deleted the JSON files and made YAML the source of truth.ExtendedContextPropagators: retarget the README link from contribextended-tracer/README.md(404) to theapi/incubatorREADME section that replaced it — remove extended tracer, which has been merged into the main repo opentelemetry-java-contrib#1129 removed that module after the code moved here.Testing done
./gradlew :api:incubator:check— 96 tests passed.curl: both old links 404, both new links 200.