Skip to content

Assert buildObserver on counter and up-down-counter in shared default meter test#8611

Open
thswlsqls wants to merge 1 commit into
open-telemetry:mainfrom
thswlsqls:test/noop-meter-build-observer-coverage
Open

Assert buildObserver on counter and up-down-counter in shared default meter test#8611
thswlsqls wants to merge 1 commit into
open-telemetry:mainfrom
thswlsqls:test/noop-meter-build-observer-coverage

Conversation

@thswlsqls

Copy link
Copy Markdown
Contributor

Description

Testing done

  • ./gradlew :api:all:test --tests DefaultMeterTest — 18 passed. ./gradlew :api:incubator:test --tests ExtendedDefaultMeterTest — 19 passed. ./gradlew :api:testing-internal:check passed.
  • Coverage gap, so tests pass both before and after the change.
  • Gap confirmed real: with a temporary UnsupportedOperationException in DefaultMeter's long-counter buildObserver(), the old test still passed and the new one failed. Probe reverted.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.66%. Comparing base (63ebd94) to head (e2d13f9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8611      +/-   ##
============================================
+ Coverage     91.63%   91.66%   +0.02%     
  Complexity    10326    10326              
============================================
  Files          1013     1013              
  Lines         27295    27295              
  Branches       3205     3205              
============================================
+ Hits          25011    25019       +8     
+ Misses         1558     1550       -8     
  Partials        726      726              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thswlsqls
thswlsqls marked this pull request as ready for review July 17, 2026 05:44
@thswlsqls
thswlsqls requested a review from a team as a code owner July 17, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant