Output event name in SystemOutLogRecordExporter#8609
Draft
thswlsqls wants to merge 1 commit into
Draft
Conversation
0791207 to
171d0bf
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8609 +/- ##
============================================
+ Coverage 91.62% 91.63% +0.01%
- Complexity 10321 10327 +6
============================================
Files 1013 1013
Lines 27287 27299 +12
Branches 3203 3206 +3
============================================
+ Hits 25001 25015 +14
+ Misses 1559 1558 -1
+ Partials 727 726 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8608
Description
SystemOutLogRecordExporter.formatLog()did not print the log record's event name; it now appends[eventName: <name>]after the severity when one is set.LogRecord.EVENT_NAME(LogStatelessMarshaler,LogMarshaler).LogRecordData.getEventName()is a stable log data-model field (stabilized in Stabilize log record event name #7277); this exporter was not updated when the field was added.Testing done
SystemOutLogRecordExporterTest#formatWithEventNamefor the event-name-present case; the existingformattest covers the absent case../gradlew :exporters:logging:check— 16 tests passed.## UnreleasedCHANGELOG entry is included. No public API change (formatLogis package-private), so no apidiff update.Related: PR #6591 updated
formatLog's body field when the data model changed.