testbed: use fluent assertThat and remove stale nanos TODO#8607
Merged
jack-berg merged 2 commits intoJul 16, 2026
Merged
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8607 +/- ##
=========================================
Coverage 91.63% 91.63%
- Complexity 10326 10327 +1
=========================================
Files 1013 1013
Lines 27295 27295
Branches 3205 3205
=========================================
+ Hits 25011 25012 +1
Misses 1558 1558
+ Partials 726 725 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/easycla |
299333a to
7762b98
Compare
jack-berg
approved these changes
Jul 16, 2026
Contributor
|
Thank you for your contribution @fossadvocate86! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two
TestUtils.assertSameTrace()methods in thesdk/traceandopentracing-shimtestbeds carry a
TODO - Include nanos in this comparison.that has been stale sincethe API was migrated to return epoch nanoseconds directly via
getEndEpochNanos().sdk/trace testbed
Replace
assertThat(a >= b).isTrue()withassertThat(a).isGreaterThanOrEqualTo(b)and remove the TODO comment.
The old form fails with
expected: true, but was: false— no diagnostic information.The new fluent form reports the actual nanosecond values on failure, making it
immediately actionable.
opentracing-shim testbed
Already used the fluent form (
.isLessThanOrEqualTo). Remove the now-stale TODOcomment.
Testing
LateSpanFinishTest(sdk/trace) — the sole caller of the sdk/trace version ✅LateSpanFinishTest(opentracing-shim) ✅OpenTelemetryInteroperabilityTest(opentracing-shim) — 2 tests that callassertSameTrace✅