Fix getMangedChannel typo in ExtendedGrpcSenderConfig#8604
Draft
thswlsqls wants to merge 1 commit into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8604 +/- ##
=========================================
Coverage 91.62% 91.62%
Complexity 10321 10321
=========================================
Files 1013 1013
Lines 27287 27287
Branches 3203 3203
=========================================
Hits 25001 25001
Misses 1559 1559
Partials 727 727 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
getMangedChannel()togetManagedChannel()onExtendedGrpcSenderConfig, and update its sole callerUpstreamGrpcSenderProvider. The typo was introduced in Refactor http, grpc senders and promote to public API #7782.exporter.internal.grpc), so this is not a public API change: no apidiff (japicmp excludes internal packages), no CHANGELOG.ImmutableGrpcSenderConfiginexporters:otlp:allandsdk-extensions:jaeger-remote-sampler) call the generated constructor positionally, so AutoValue regenerates the property under the corrected name with no source edit.Testing done
./gradlew :exporters:common:check :exporters:sender:grpc-managed-channel:check— passed../gradlew :exporters:otlp:all:compileJava :sdk-extensions:jaeger-remote-sampler:compileJava— passed; both AutoValue impls compile against the renamed method.