Skip to content

Fix getMangedChannel typo in ExtendedGrpcSenderConfig#8604

Draft
thswlsqls wants to merge 1 commit into
open-telemetry:mainfrom
thswlsqls:fix/grpc-sender-config-managed-channel-typo
Draft

Fix getMangedChannel typo in ExtendedGrpcSenderConfig#8604
thswlsqls wants to merge 1 commit into
open-telemetry:mainfrom
thswlsqls:fix/grpc-sender-config-managed-channel-typo

Conversation

@thswlsqls

Copy link
Copy Markdown
Contributor

Description

  • Rename the misspelled getter getMangedChannel() to getManagedChannel() on ExtendedGrpcSenderConfig, and update its sole caller UpstreamGrpcSenderProvider. The typo was introduced in Refactor http, grpc senders and promote to public API #7782.
  • The interface is internal (exporter.internal.grpc), so this is not a public API change: no apidiff (japicmp excludes internal packages), no CHANGELOG.
  • The two AutoValue impls (ImmutableGrpcSenderConfig in exporters:otlp:all and sdk-extensions:jaeger-remote-sampler) call the generated constructor positionally, so AutoValue regenerates the property under the corrected name with no source edit.

Testing done

  • Trivial typo on an internal identifier; behavior unchanged, no test added.
  • ./gradlew :exporters:common:check :exporters:sender:grpc-managed-channel:check — passed.
  • ./gradlew :exporters:otlp:all:compileJava :sdk-extensions:jaeger-remote-sampler:compileJava — passed; both AutoValue impls compile against the renamed method.

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.62%. Comparing base (6f6e146) to head (b999356).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8604   +/-   ##
=========================================
  Coverage     91.62%   91.62%           
  Complexity    10321    10321           
=========================================
  Files          1013     1013           
  Lines         27287    27287           
  Branches       3203     3203           
=========================================
  Hits          25001    25001           
  Misses         1559     1559           
  Partials        727      727           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant