Fix copy-paste class javadoc on OTLP AnyValue stateless marshalers#8602
Draft
thswlsqls wants to merge 1 commit into
Draft
Fix copy-paste class javadoc on OTLP AnyValue stateless marshalers#8602thswlsqls wants to merge 1 commit into
thswlsqls wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8602 +/- ##
============================================
+ Coverage 91.55% 91.62% +0.07%
- Complexity 10262 10321 +59
============================================
Files 1013 1013
Lines 27102 27287 +185
Branches 3182 3203 +21
============================================
+ Hits 24812 25001 +189
+ Misses 1565 1559 -6
- Partials 725 727 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three stateless marshalers in
io.opentelemetry.exporter.internal.otlpcarry a class javadoc copy-pasted from the KeyValue marshaler, so the description or the sibling{@link}no longer matches what the class marshals.AnyValueStatelessMarshalermarshals a singleValue(AnyValue), not "key value pairs" — corrected toA Marshaler of {@link Value}.ArrayAnyValueStatelessMarshalermarshals a list of values (ArrayValue.VALUES) — corrected toA Marshaler of array values.KeyValueStatelessMarshaler's description is right, but itsSee {@link ...}pointed atAnyValueMarshaler. Every sibling stateless marshaler links to its own non-stateless counterpart (e.g.AttributeKeyValueStatelessMarshaler→KeyValueMarshaler), so this now links toKeyValueMarshaler.Internal package only: no behavior, wire output, public API, or signature change.
Testing done
./gradlew :exporters:otlp:common:checkpassed (spotless, ErrorProne{@link}validation, jApiCmp, unit tests).CHANGELOG.mdentry (not user-facing).