Skip to content

[SDK] feat: exemplar filters#4267

Open
proost wants to merge 4 commits into
open-telemetry:mainfrom
proost:feat-exemplar-filters
Open

[SDK] feat: exemplar filters#4267
proost wants to merge 4 commits into
open-telemetry:mainfrom
proost:feat-exemplar-filters

Conversation

@proost

@proost proost commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Fixes #4178, #2526

Changes

Breaking Change is accompanied, But Because this is preview version, I think acceptable.

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@proost
proost requested a review from a team as a code owner July 18, 2026 05:50
@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.18182% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.23%. Comparing base (3e4296e) to head (f99c77b).

Files with missing lines Patch % Lines
...sdk/metrics/exemplar/filtered_exemplar_reservoir.h 88.89% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4267      +/-   ##
==========================================
+ Coverage   78.15%   78.23%   +0.08%     
==========================================
  Files         440      441       +1     
  Lines       18736    18755      +19     
==========================================
+ Hits        14642    14671      +29     
+ Misses       4094     4084      -10     
Files with missing lines Coverage Δ
...ude/opentelemetry/sdk/metrics/exemplar/reservoir.h 100.00% <ø> (ø)
...entelemetry/sdk/metrics/exemplar/reservoir_utils.h 100.00% <100.00%> (ø)
...telemetry/sdk/metrics/state/async_metric_storage.h 95.24% <100.00%> (+4.33%) ⬆️
...ntelemetry/sdk/metrics/state/sync_metric_storage.h 90.00% <100.00%> (+7.50%) ⬆️
sdk/src/metrics/exemplar/reservoir.cc 75.00% <100.00%> (+8.34%) ⬆️
sdk/src/metrics/meter.cc 81.36% <ø> (ø)
...sdk/metrics/exemplar/filtered_exemplar_reservoir.h 88.89% <88.89%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is support for exemplars still experimental/preview?

1 participant