fix: render literal Chocolatey download URLs

[rianjs]

Render both architecture download URLs as literals in Chocolatey packages so Business Internalizer can resolve them. Keep this staged until the confluence-cli balloon passes licensed internalization and offline install. The shared release workflow must ship first.

[rianjs]

TDD assessment: spotify-cli PR #50

Finding

P2 — The new architecture-to-URL binding has no behavioral check

packaging/chocolatey/tools/chocolateyInstall.ps1:11 now chooses separate URL variables for ARM64 and AMD64, but the PR test only confirms that both placeholder tokens exist in the source template (scripts/verify-package-render.sh:70). The release snapshot does not build a Chocolatey package or execute chocolateyInstall.ps1.

The shared-workflow work in open-cli-collective/.github#48 covers rendering both literal URLs and rejects placeholders from the packed .nupkg, but it also does not execute this package's ARM64/AMD64 branch. Consequently, swapping $urlArm64 and $urlAmd64, or pairing either URL with the other architecture's checksum, would pass every current check while breaking the approved requirement to preserve architecture selection.

Add one small PowerShell test that dot-sources the rendered installer with Install-ChocolateyZipPackage mocked, once with PROCESSOR_ARCHITECTURE=ARM64 and once with an AMD64 OS. Assert the URL and SHA256 passed to the mock match their corresponding architecture-specific values. This keeps the test at the only new behavior the shared renderer cannot validate.

[rianjs-bot]

Automated PR Review

Reviewed commit: 7f7ee111cac1
Profile: codex-rianjs-bot - Posting as: rianjs-bot[bot]

Summary

Reviewer	Findings
automation:ci-release	0
policies:conventions	0

Reviewer Coverage

• automation:ci-release — complete (broad); skipped: none; constraints: Review limited to the assigned CI/release/package files; the reusable shared release workflow is externally referenced and not available locally.
• policies:conventions — complete (broad); skipped: none; constraints: No local cli-common or shared .github convenience documentation was available; the canonical GitHub sources could not be fetched in this environment.

Inspected files (4)

• .github/workflows/release-build-check.yml
• packaging/chocolatey/tools/chocolateyInstall.ps1
• scripts/test-chocolatey-install.ps1
• scripts/verify-package-render.sh

0 PR discussion threads considered. 0 summarized; 0 resolved.

---

Completed in 1m 35s | gpt-5.6-terra | cr 0.10.314

Field	Value
Model	gpt-5.6-terra
Reviewers	automation:ci-release, policies:conventions
Engine	codex_cli · gpt-5.6-terra
Reviewed by	cr · rianjs-bot[bot]
Duration	1m 35s wall · 2m 19s compute
Cost	unavailable
Tokens	461.6k in / 5.5k out

Per-workstream usage

• orchestrator-selection — gpt-5.6-terra
  • In: 49.8k
  • Out: 537
  • Cache read: 43.3k
  • Cache create: unavailable
  • Cost: unavailable
  • Duration: 17s
• automation:ci-release — gpt-5.6-terra
  • In: 185.4k
  • Out: 2.4k
  • Cache read: 159.0k
  • Cache create: unavailable
  • Cost: unavailable
  • Duration: 58s
• policies:conventions — gpt-5.6-terra
  • In: 158.3k
  • Out: 2.0k
  • Cache read: 139.5k
  • Cache create: unavailable
  • Cost: unavailable
  • Duration: 58s
• orchestrator-rollup — gpt-5.6-terra
  • In: 68.1k
  • Out: 573
  • Cache read: 59.4k
  • Cache create: unavailable
  • Cost: unavailable
  • Duration: 4s