Repository navigation
feat(ui): pick the AI model from the resolved CLI's models - #8
Merged
Merged
Conversation
Model is a list of the aliases the resolved agent CLI accepts, with Other for any name, and is hidden for a custom command, which receives no model. Switching provider resets the model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settings' Model field was a free-text box with no hint of valid values. It is now a list that follows the provider:
Evidence
Headless Chromium against
lest uion the examples, 1440x900 at 2x. A Playwright script picked an agent CLI provider, chose Sonnet, then Other with a full model name, and reloaded: the choice persisted, and the row disappeared after switching to Custom command.Sonnet chosen; the status line reports it:
Other with a full model name:
Checks
make checkpasses (including a newmodelChoicestest). Denylist scan clean.