Repository navigation
fix: run secret commands in the project root - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
commandsecret backend ran in whatever directorylestwas started from, so a backend that calls a script kept in the project (./bin/read-secret "$LEST_SECRET_NAME") worked from the project root and failed from anywhere else, including the UI started elsewhere.The command now runs in the project root with
LEST_PROJECT_DIRset, the same as step processes.Resolver::newtakes the project. The docs say where the command runs.Test: the secrets unit test runs the command in a temporary root and checks for a file there.