Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
operation not permitted. The result was one run/fail, zero pass/skip, exit 1, with no timeout. This occurred beforeLaunchProcess, so no shell or Python fixture helper was launched.make checkwas not run.Scope and limitations
Only
internal/llm/subprocess_launch_unix_test.gochanges, based on main999e59ddfc74a67ffeef3c4b4a78a8528365afe6. Production source is unchanged.This is fixture resource-release hygiene discovered while investigating #613. It does not fix, close, or establish a reproduction of the reported macOS production orphan issue. The Go test does not reap the adopted detached Python child; the release protocol establishes cooperative closure of the held resources, not OS reaping.
No alternate IPC transport was tried after the local permission denial. Linux runtime evidence is limited to the hosted test modes below; macOS runtime behavior remains unvalidated. Keep this PR in draft; no merge is authorized.
Hosted CI
fee40bd667a1b90a133d72bc0ce6c0e12c627363completed with nine passing jobs and one lint failure: errorlint requirederrors.Isfor the control-channel EOF check. The target test explicitly passed in its normal, opt-out and static-smoke jobs. That failed run remains part of the validation record.errorsimport and replaces the direct EOF comparison witherrors.Is. Nonwriting local formatting checks passed; the denied local IPC test was not retried.2d48d94caf01118c18cbd07b282287fa9dd2d51c: all 10 jobs passed, including lint, the test modes, three OS builds, the build aggregate, identity and title checks.TestLaunchProcessUnblocksReadOnCanceledContextpassing in the normal Linux test job (0.13s), 1Password-opt-out job (0.13s), and CGO-disabled static-smoke job (0.14s).make checkremain unrun. Hosted success does not erase the separate local IPC failure or establish OS reaping or a production fix for Claude reviewer tool processes can outlive the review run (orphaned process at 100% CPU for 4 days) #613.Both CI runs were triggered by ordinary PR activity; no manual workflow rerun was used. The PR remains a draft and unmerged.