Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #621.
Collect bounded per-request usage evidence for the direct OpenAI Responses adapter and retain it across structured-output corrections, transport retries, cache reloads, and task resets.
This is collection-only. Task-history completeness remains false because a fresh accounting origin is not established. Interrupted, missing, conflicting, legacy, opaque, and overflowing evidence stays uncertain. No request pricing, invoice estimate, catalog activation, or estimator activation is added. Per-attempt crash durability and power-loss durability are not claimed.
Stack and source scope
This draft targets #662's branch,
dot/issue597-tool-evidence-v4-20261008, pinned at982341589d5c3db76ac260626faa325df4ff0dc1. It also depends on #666 at29edd5c6877be9cda7341ee6f5b11b0acdcff5fb.The source was reviewed against the exact #662 tree with only #666's
internal/llmadapters/api.goandapi_test.gooverlaid. The collection slice changes 15 paths over that composition. Relative to #662, this PR changes 16 paths because it also carries #666's unchangedapi_test.go; the adapter source includes both the cache-write prerequisite and collection changes. Neither dependency's passing checks are inherited as validation of this tree.Original reviewed source009 tree:
1e596df55fa9e5f1baccde01d4f7f21cb814c446.Current lint-correction head:
4c1d9887e3d88fac17b749630936ed5e0ebefd77; tree5d5686bf08641900a73cfab7acd13f8131b12b6c.The current head is a non-force child of the original publication head. It applies a separately reviewed five-file lint correction: equivalent bounded length calculations, fixture-read confinement, comments/names, and a documented test-only nil-context exception. All 13 fixture files are unchanged.
Source009 inventory SHA-256:
8a37ba4e7c61915f1a14c54799da00631449a10358ca43b51f6cae491e7e00fc.All 423 source files and modes were checked. Only the 16 listed source, documentation, test, and synthetic-fixture paths differ from #662.
go.mod,go.sum, and workflow files are unchanged. The catalog-only draft #667 is separate and is not included.Validation and limits
Current lint-correction head
Head
4c1d9887e3d88fac17b749630936ed5e0ebefd77passed source review, bounded formatting, and remote verification of all 423 files and modes.Hosted CI run 37757949065 passed all 10 jobs: lint, standard tests, no-1Password opt-out tests, static smoke, Linux/macOS/Windows builds, the build aggregate, PR title, and identity. The checkout was synthetic merge
02aa567e056da311120c0dd680f11f0d053a0794; its independently verified tree is the exact successor5d5686bf08641900a73cfab7acd13f8131b12b6c.All 43 authored request-cost tests passed again in each of the three test profiles, totaling 73 selected test/subtest pass events per profile, with no selected skips or failures. The profiles used Go 1.26.8 on Linux and reported no cached package results. Standard/static profiles each recorded 3,677 pass events and four unrelated skips; opt-out recorded 3,661 pass events and 17 unrelated skips, in the same categories retained below. Lint reported zero issues.
These are new results for the successor, separate from the original run below. Local target tests, compilation, lint, race validation, and the 12 historical-defect controls remain NOT RUN. Hosted success does not establish provider-invoice completeness, fresh accounting origin, or estimator readiness.
Original source009 hosted evidence
813c993708cd13da830c299948b5994eb110b05e. Its checkout was synthetic mergee1e8a5d04668b078131774710fa88fbe01d47acd, whose verified tree equals1e596df55fa9e5f1baccde01d4f7f21cb814c446.These hosted results cover only the exact source and profiles above. They do not supply validation for a later correction or inherit checks from either dependency. The earlier combined integration attempt remains UNKNOWN and supplies no test credit for this PR.
This remains a draft. Merge readiness is unestablished and #621 stays open.