Repository navigation
fix(release): adopt canonical Windows archive resolver - #644
Merged
Merged
Conversation
monit-reviewer
approved these changes
Oct 2, 2026
monit-reviewer
left a comment
There was a problem hiding this comment.
Automated PR Review
Reviewed commit: e69824e0001c
Profile: codex-monit-reviewer - Posting as: monit-reviewer
Summary
| Reviewer | Findings |
|---|---|
| automation:ci-release | 0 |
| policies:conventions | 0 |
Reviewer Coverage
automation:ci-release— complete (broad); skipped: none; constraints: Consumer actionlint and resolver/Homebrew shell tests passed. Chocolatey-push tests could not collect because defusedxml was unavailable. PowerShell rendering and live Windows package publication were not executed; static inspection does not establish live publication success. Reviewed the consumer pin and exact shared-commit diff using a local shared repository; GitHub retrieval was unavailable.policies:conventions— complete (broad); skipped: none; constraints: Canonical shared standards and pinned workflow could not be fetched; sibling convenience copies were unavailable. Shared resolver behavior and live publication were not independently verified. Review scoped to the reusable release workflow pin change and visible repository guidance, packaging configuration, and supplied evidence.
Inspected files (1)
.github/workflows/release.yml
0 PR discussion threads considered. 0 summarized; 0 resolved.
Completed in 2m 15s | gpt-6.1-sol | cr 0.10.319
| Field | Value |
|---|---|
| Model | gpt-6.1-sol |
| Reviewers | automation:ci-release, policies:conventions |
| Engine | codex_cli · gpt-6.1-sol |
| Reviewed by | cr · monit-reviewer |
| Duration | 2m 15s wall · 2m 32s compute |
| Cost | unavailable |
| Tokens | 670.6k in / 2.9k out |
Per-workstream usage
orchestrator-selection— gpt-6.1-sol- In: 79.1k
- Out: 333
- Cache read: 58.6k
- Cache create: unavailable
- Cost: unavailable
- Duration: 20s
automation:ci-release— gpt-6.1-sol- In: 399.5k
- Out: 1.6k
- Cache read: 358.7k
- Cache create: unavailable
- Cost: unavailable
- Duration: 1m 32s
policies:conventions— gpt-6.1-sol- In: 79.3k
- Out: 463
- Cache read: 59.0k
- Cache create: unavailable
- Cost: unavailable
- Duration: 28s
orchestrator-rollup— gpt-6.1-sol- In: 112.8k
- Out: 419
- Cache read: 90.8k
- Cache create: unavailable
- Cost: unavailable
- Duration: 10s
Member
Author
|
Post-merge verification: v0.10.322 points to merge commit
Historical failed runs are unchanged. This verification uses the new merged commit and release. It does not claim a live Pi/provider integration result or resolve compatibility of older installed Pi versions. |
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update only the reusable release workflow pin to
776a11fe7a86dccb73bccb5dbf3824fe2ec8d4af, which includes the merged canonical Windows archive resolver in open-cli-collective/.github#49.The failed v0.10.320 release lists
cr.exein each Windows archive'sextra.Binaries, while the identity manifest declarescr. The old resolver returned zero matches and emitted empty matrices, preventing the Windows package jobs from starting. The updated resolver matches both architectures and fails loudly for missing assets.Evidence
Using the actual
distartifact from the failed release:cr_v0.10.320_windows_amd64.zipcr_v0.10.320_windows_arm64.zipBoth Chocolatey and WinGet matrices contain those exact published asset names. The shared resolver regression also verifies missing AMD64 assets fail loudly.
Validation: consumer workflow
actionlintpasses; shared resolver, Homebrew modernization/idempotency and alias tests pass; all 28 Chocolatey-push tests pass. The Windows PowerShell renderer was inspected but has not yet run here.The intervening shared changes were inspected: action dependency pins, Homebrew install-step modernization and staged-path correction, and backward-compatible Chocolatey rendering. Existing package templates without URL placeholders keep their legacy path; this does not apply the static-URL migration staged in #634. Package identity, secrets, triggers, production code, and CI pins remain unchanged.
The fixture/artifact replay proves matrix resolution, not live Windows package publication. A successful subsequent release is still required. No published tag or asset is changed by this PR; workflow-only changes do not automatically mint a new release.