Skip to content

fix(release): adopt canonical Windows archive resolver - #644

Merged
piekstra merged 1 commit into
mainfrom
piekstra/fix-windows-release-resolver
Oct 2, 2026
Merged

piekstra merged 1 commit into
mainfrom
piekstra/fix-windows-release-resolver

Conversation

@piekstra

@piekstra piekstra commented Oct 2, 2026

Copy link
Copy Markdown
Member

Summary

Update only the reusable release workflow pin to 776a11fe7a86dccb73bccb5dbf3824fe2ec8d4af, which includes the merged canonical Windows archive resolver in open-cli-collective/.github#49.

The failed v0.10.320 release lists cr.exe in each Windows archive's extra.Binaries, while the identity manifest declares cr. The old resolver returned zero matches and emitted empty matrices, preventing the Windows package jobs from starting. The updated resolver matches both architectures and fails loudly for missing assets.

Evidence

Using the actual dist artifact from the failed release:

Resolver AMD64 ARM64
Old pinned workflow zero matches matrix not produced
Updated shared action cr_v0.10.320_windows_amd64.zip cr_v0.10.320_windows_arm64.zip

Both Chocolatey and WinGet matrices contain those exact published asset names. The shared resolver regression also verifies missing AMD64 assets fail loudly.

Validation: consumer workflow actionlint passes; shared resolver, Homebrew modernization/idempotency and alias tests pass; all 28 Chocolatey-push tests pass. The Windows PowerShell renderer was inspected but has not yet run here.

The intervening shared changes were inspected: action dependency pins, Homebrew install-step modernization and staged-path correction, and backward-compatible Chocolatey rendering. Existing package templates without URL placeholders keep their legacy path; this does not apply the static-URL migration staged in #634. Package identity, secrets, triggers, production code, and CI pins remain unchanged.

The fixture/artifact replay proves matrix resolution, not live Windows package publication. A successful subsequent release is still required. No published tag or asset is changed by this PR; workflow-only changes do not automatically mint a new release.

@monit-reviewer monit-reviewer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated PR Review

Reviewed commit: e69824e0001c
Profile: codex-monit-reviewer - Posting as: monit-reviewer

Summary

Reviewer Findings
automation:ci-release 0
policies:conventions 0

Reviewer Coverage

  • automation:ci-release — complete (broad); skipped: none; constraints: Consumer actionlint and resolver/Homebrew shell tests passed. Chocolatey-push tests could not collect because defusedxml was unavailable. PowerShell rendering and live Windows package publication were not executed; static inspection does not establish live publication success. Reviewed the consumer pin and exact shared-commit diff using a local shared repository; GitHub retrieval was unavailable.
  • policies:conventions — complete (broad); skipped: none; constraints: Canonical shared standards and pinned workflow could not be fetched; sibling convenience copies were unavailable. Shared resolver behavior and live publication were not independently verified. Review scoped to the reusable release workflow pin change and visible repository guidance, packaging configuration, and supplied evidence.
Inspected files (1)
  • .github/workflows/release.yml

0 PR discussion threads considered. 0 summarized; 0 resolved.


Completed in 2m 15s | gpt-6.1-sol | cr 0.10.319
Field Value
Model gpt-6.1-sol
Reviewers automation:ci-release, policies:conventions
Engine codex_cli · gpt-6.1-sol
Reviewed by cr · monit-reviewer
Duration 2m 15s wall · 2m 32s compute
Cost unavailable
Tokens 670.6k in / 2.9k out

Per-workstream usage

  • orchestrator-selection — gpt-6.1-sol
    • In: 79.1k
    • Out: 333
    • Cache read: 58.6k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 20s
  • automation:ci-release — gpt-6.1-sol
    • In: 399.5k
    • Out: 1.6k
    • Cache read: 358.7k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 1m 32s
  • policies:conventions — gpt-6.1-sol
    • In: 79.3k
    • Out: 463
    • Cache read: 59.0k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 28s
  • orchestrator-rollup — gpt-6.1-sol
    • In: 112.8k
    • Out: 419
    • Cache read: 90.8k
    • Cache create: unavailable
    • Cost: unavailable
    • Duration: 10s

@piekstra
piekstra marked this pull request as ready for review October 2, 2026 11:35
@piekstra
piekstra merged commit 366ec7a into main Oct 2, 2026
10 checks passed
@piekstra
piekstra deleted the piekstra/fix-windows-release-resolver branch October 2, 2026 11:37
@piekstra

piekstra commented Oct 2, 2026

Copy link
Copy Markdown
Member Author

Post-merge verification: v0.10.322 points to merge commit 015bba069b03c5117a54dd7236a65f3b73612730 and includes both #643 and #644.

  • Main CI passed, including both test jobs.
  • Release passed all five jobs: GoReleaser, Homebrew, Chocolatey, WinGet, and Linux dispatch. The real Windows archive resolver passed and both Windows jobs ran.
  • Downloaded the Darwin ARM64 archive into an isolated temporary directory. SHA-256 matches the published checksum; cr --version reports 0.10.322 and the exact merge commit. Build metadata reports CGO_ENABLED=1 and vcs.modified=false. The Homebrew cask pins 0.10.322 with the same archive checksum. No shared installation was changed.
  • Chocolatey accepted codereview-cli.0.10.322.nupkg; its API currently reports Submitted and IsApproved=false. Availability still awaits moderation.
  • WinGet submitted microsoft/winget-pkgs #445652; its validation and merge remain pending.
  • Downstream Linux repository publication is still running; the successful dispatch is not proof of completed repository publication.

Historical failed runs are unchanged. This verification uses the new merged commit and release. It does not claim a live Pi/provider integration result or resolve compatibility of older installed Pi versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants