Skip to content

ci: bound the coordinated upgrade e2e step and keep its log - #523

Open
andrebrait wants to merge 1 commit into
mainfrom
ci/upgrade-e2e-step-timeout
Open

andrebrait wants to merge 1 commit into
mainfrom
ci/upgrade-e2e-step-timeout

Conversation

@andrebrait

@andrebrait andrebrait commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

The "Native compiled coordinated upgrade and rollback" step stalled on windows-latest until the 60-minute job limit twice (main run 44136326452 attempt 1, #520 run 44197018381), and GitHub kept no log, so the cause is unknown.

  • timeout-minutes: 25 on the step (each test is already bounded at 15 min).
  • Suite output goes to $RUNNER_TEMP/compiled-upgrade.log with stdin from /dev/null, then is printed: a detached process (update worker, host) that inherits the step pipe keeps a Windows step open after bun exits.
  • On failure the log is uploaded as compiled-upgrade-<os>.

No product code changes.

Summary by CodeRabbit

  • Tests
    • The coordinated upgrade and rollback checks now have a longer overall time limit while retaining their existing per-test limit.
    • Test output is preserved and displayed after the checks run. When checks fail, the output is uploaded for review unless the workflow is cancelled.
  • User Impact
    • No changes to user-facing functionality.

Twice on windows-latest the step ran until the 60-minute job limit and
GitHub kept no log. Give it 25 minutes, write the suite output to a file
(a detached process holding the step pipe keeps a Windows step open) and
upload it when the step fails.
@coderabbitai

coderabbitai Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The verification workflow adds a 25-minute step timeout for the compiled upgrade test, captures and prints its output, and preserves its exit status. On eligible failures, it uploads the log as an OS-specific artifact.

Changes: Compiled upgrade test diagnostics

Layer / File(s) Summary
Capture and upload test logs
.github/workflows/verify-pr.yml
The test step writes output to a runner-temp log, prints it, and exits with the test status. A failure-only step uploads the log as an OS-specific artifact unless the workflow is cancelled. The test command and its 15-minute test timeout remain unchanged.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

  • ompweb-dev/ompweb#520: The PR description identifies a potential connection to verify-pr.yml through the compiled runner path and build step.
Merge Risk: Minimal · up to 7c304

This change only adds diagnostics and a time bound to a CI step. It does not touch product code, so merge risk is minimal.

Security architecture risk: Minimal · up to 7c304

The change bounds a CI test step and preserves diagnostic output after eligible failures. No expanded production privileges or material regression in security, failure containment, or rollback was established.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — The introduced data-retention surface is the verification run's test-output log, not a production data directory. The upload configuration does not collect the scratch home, host configuration, or repository workspace.

Trust Boundaries and Controls

  • observed — The workflow continues to use pull_request rather than pull_request_target, and its declared repository permissions remain read-only. The PR adds no permission override or secret expression to the diagnostic steps.

Resilience and Maintainability Implications

  • observed — On normal command completion, test failure is captured and re-emitted rather than converted to success. Diagnostic preservation is best-effort: cancellation suppresses upload, a missing file is tolerated, and the workflow does not guarantee log completeness after interruption.
Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the two changes the PR makes: it bounds the coordinated upgrade e2e step with a timeout and keeps the step's output in a log file that is uploaded on failure. The raw summary confirms …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the two changes the PR makes: it bounds the coordinated upgrade e2e step with a timeout and keeps the step's output in a log file that is uploaded on failure. The raw summary confirms a 25-minute step timeout, a runner-temp log captured and printed, and an artifact upload on failure. The title is specific and matches the main change.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 401f06b6-0ebf-41b1-a6c3-9867f2fc1bf5
Commits

Reviewing files that changed from the base of the PR and between 8efbd9b and 7c304ae.

Files selected for processing: 1

  • .github/workflows/verify-pr.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant