Repository navigation
fix(runner): follow omp 18.22 run lifecycle - #518
Closed
andrebrait wants to merge 2 commits into
Closed
andrebrait wants to merge 2 commits into
andrebrait wants to merge 2 commits into
Conversation
omp 18.22 (upstream 0730879325) ends a run once and pauses loops with agent_pause; the settle API became isRunActive/wakeSources/waitForRunEnd. Map them onto the unchanged channel wire with upstream's own loop-end wire codec and RPC settle watcher, and pin the runner to v18.22.0-int.202611171027.gec3956c.
Contributor
Collaborator
Author
|
Superseded: the runner moved into the oh-my-pi fork ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
omp 18.22 (upstream can1357/oh-my-pi@0730879325) ends a run once and pauses loops with
agent_pause;waitForSessionSettlement/hasPendingAsyncWorkbecameisRunActive/wakeSources/waitForRunEnd. The newest fork build no longer compiled against the runner, which is why Binary prerelease fails on main.runner/tov18.22.0-int.202611171027.gec3956c.events.tsforwards through upstream'stoWireEvent(session/loop-end-wire):agent_pause→agent_end {isTerminal:false, yielded, awaitingAsyncWork}, the run's end →agent_end {isTerminal:true, yielded:true}. The runner's own settle watcher is replaced by upstream'sRpcSessionSettleWatcher.goal.ts/prompt-results.tsfollow the same conditions as upstream's RPC mode;get_state.hasPendingAsyncWork=wakeSources !== undefined;edit_messagerefuses whileisRunActive(also covers a run paused on a child agent).Verified: runner
tsc -p .clean,bun test30 pass; linux-x64 binary--smoke-testok; server tests touchingisTerminal/session_settled(11 files) 764 pass.Summary by CodeRabbit