fix: point PR template contributing link at .github/CONTRIBUTING.md - #6
Merged
Merged
Conversation
The PR template links to CONTRIBUTING.md#your-first-code-contribution, but the guide lives at .github/CONTRIBUTING.md (identical to the website page apps/web/content/docs/getting-started/contributing.mdx), so the root path 404s. Fix the link path and remove the root CONTRIBUTING.md that duplicated the existing .github file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream target
themesberg/flowbite-react — no issue; self-found gap. The PR template links to a
CONTRIBUTING.mdthat 404s.What changed
CONTRIBUTING.md#your-first-code-contribution(404) →.github/CONTRIBUTING.md#your-first-code-contribution(200).CONTRIBUTING.mdthat duplicated the existing.github/CONTRIBUTING.md(the two files were the same contributing-gen content).Why
The template's first checkbox links to
https://github.com/themesberg/flowbite-react/blob/main/CONTRIBUTING.md#your-first-code-contribution, which 404s because the guide actually lives at.github/CONTRIBUTING.md(verified: identical to the website pageapps/web/content/docs/getting-started/contributing.mdx). GitHub does not redirect the root path to.github/, so the link path is simply wrong.How to verify
curl -s -o /dev/null -w '%{http_code}' https://github.com/themesberg/flowbite-react/blob/main/.github/CONTRIBUTING.md#your-first-code-contributionreturns200.CONTRIBUTING.mdno longer exists;.github/CONTRIBUTING.mdis unchanged.Coverage
N/A — docs/link fix, no coverage tool applies.
Checks run locally
.github/CONTRIBUTING.mdexists upstream and on the fork (shaedd224e), with the "Your First Code Contribution" section at the anchor.CONTRIBUTING.mdremoved;.github/CONTRIBUTING.mduntouched.Style / template compliance
Follows the repo's PR template (checkbox above) and Conventional Commits commit style (
fix: ...). One logical change: correct the link path.Confidence: HIGH
Link path verified both ways (404 old, 200 new); the guide content already existed and is untouched.
AI assistance
Drafted with AI assistance. The gap was found and verified against the current repo (root link 404s,
.github/CONTRIBUTING.mdexists with the same content), the fix was verified with curl, and the diff was reviewed line by line before opening.Recommendation
Ready to send upstream as-is.
PROMOTION NOTE (remove this section before/when opening against upstream):
Prerequisites: none. No CLA/DCO bot found in
themesberg/flowbite-react; no signed-commit requirement found.