Repository navigation
fix(omvs): CollectionManager subclasses run the base constructor; delete cascade reaches the server (ISSUE-126, ISSUE-127) - #429
Merged
dwolfson merged 2 commits intoOct 5, 2026
Conversation
…structor; delete cascade reaches the server (ISSUE-126, ISSUE-127) ISSUE-126: ProductManager and DigitalBusiness called ServerClient.__init__, skipping CollectionManager.__init__, so collection_command_root and metadata_expert_command_root were never set and 27 inherited collection methods raised AttributeError. A structural test now fails if any OMVS client skips its base constructor. ISSUE-127: _async_delete_collection and _async_delete_digital_product pre-filled a body dict, which made the shared helper ignore cascade, so delete_collection(cascade=True) and delete_digital_product(cascade=True) never sent cascadeDelete. Both now pass None so the helper applies it. (A scan of all 42 callers found no other site with the pattern.) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two pyegeria bugs found while cleaning up the live check for #427 (logged as ISSUE-126 and ISSUE-127; entries updated).
ISSUE-126:
ProductManager.__init__andDigitalBusiness.__init__calledServerClient.__init__instead ofCollectionManager.__init__(asGlossaryManagercorrectly does), socollection_command_rootandmetadata_expert_command_rootwere never set and the 27 inherited collection methods raisedAttributeErroron both. They now callCollectionManager.__init__. A scan of all 91 classes inpyegeria/omvs/found no other subclass with this problem.ISSUE-127:
_async_delete_collectionand_async_delete_digital_productpre-filledbody = {"class": "DeleteElementRequestBody"}. The shared_async_delete_element_requestonly appliescascadewhen it builds the body itself, sodelete_collection(cascade=True)anddelete_digital_product(cascade=True)silently never sentcascadeDelete(the same shape as ISSUE-62). Both now passNone. A scan of all 42 callers of the helper found no other site that pre-fills a body and passes a cascade flag. The helper itself is unchanged: an explicit body dict still supersedescascade, as documented. Also corrects a wrong key in a docstring sample (cascadedDelete->cascadeDelete).Test plan
test_collection_manager_subclasses.py(12 tests), including a structural test that fails if any OMVS client skips its base constructor, and body-capture tests forcascadeDelete. 8 of them fail on the old code and all pass now.tests/micro-testspasses locally🤖 Generated with Claude Code