Repository navigation
feat(sdk): add the DataSetContent and resource-connection audit-gap methods - #426
Merged
Merged
Conversation
…ethods
From the refreshed Egeria .http collections (scripts/omvs_audit.py):
asset-maker: update_data_set_content and detach_data_set_content_relationship
address ONE DataSetContent relationship by its own GUID. DataSetContent is
multi-link, so the existing attach/detach (by the two linked elements) cannot
single one out.
connection-maker: link_resource_to_connection and
detach_resource_from_connection generalise the asset-only
link_asset_to_connection / detach_asset_from_connection to any element that has
a digital resource (/elements/{}/connections/{}/attach|detach).
The audit now reports 0 missing for both services. Unit-tested only (URL, verb
and body captured); none of this was verified against a live server.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four of the five small audit gaps found by
scripts/omvs_audit.pyagainst the refreshed Egeria.httpcollections:update_data_set_contentanddetach_data_set_content_relationshipact on ONEDataSetContentrelationship by its own GUID (/data-set-content/{guid}/update|detach). DataSetContent is multi-link, so the existing attach/detach (addressed by the two linked elements) cannot single one out.link_resource_to_connectionanddetach_resource_from_connection(/elements/{}/connections/{}/attach|detach) generalise the asset-onlylink_asset_to_connection/detach_asset_from_connectionto any element with a digital resource._async_update_relationship_request,_async_new_relationship_request,_async_delete_relationship_request), whosepropertiesare plain dicts, so no DataSetContent / ResourceConnection property is dropped. New public methods carry@dynamic_catch(connection_maker had no other uses of it; CLAUDE.md says all public methods do).Not included: product-catalog
getGovernanceActionProcessesByName. Nopyegeria/omvsmodule serves/product-catalog/URLs at all (the audit maps a service toomvs/<service>.pyand there is noproduct_catalog.py), so there is nowhere obvious to put it; that needs a decision on module placement rather than a guess.Test plan
test_audit_gap_small_methods.py) capture the verb, URL and body for each method, including that the new DataSetContent calls do not reuse the two-element/data-sets/...pathstests/micro-testspassesscripts/omvs_audit.py --service asset-makerand--service connection-maker: 0 missing, 0 mismatched (were 2 and 2 missing)🤖 Generated with Claude Code