Repository navigation
fix(asset_maker): catalog target reads no longer send a relationship type (ISSUE-122) - #421
Merged
Merged
Conversation
…me (ISSUE-122) get_catalog_target(s) put the relationship type name "CatalogTarget" in the request body as metadataElementTypeName; the server rejects it with OMAG-COMMON-400-019. Add filter_results_by_type to _async_get_guid_request (mirroring the results helper) and pass False from both methods. Live verification also showed get_catalog_target's DICT/MD output was blank because the endpoint returns a relationship, so add a small formatter for it. CatalogTargetProperties gains connectionName, metadataCollectionQualifiedName, permittedSynchronization and deleteMethod, which extra='ignore' was dropping. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
The screen filters on settings.User_Profile.user_name (EGERIA_USER), falling back to garygeeke only when unset; the test hard-coded garygeeke as 'mine', so it failed on any machine with EGERIA_USER set to another user. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
Live verification showed the relationship's elementAtEnd1/2 are element stubs (guid/uniqueName/type) with no properties block, so the formatter's connector and target names were blank. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
dwolfson
added a commit
to dwolfson/egeria-python
that referenced
this pull request
Oct 5, 2026
… pending The entry still said 'fixed on branch ..., pending PR/merge'; that branch merged in odpi#421 and shipped in 6.1.28 (and 6.1.29). Re-verified read-only on the 2026-10-05 rebuilt platform: get_catalog_targets returns 'No elements found' in all three formats with no server error. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
dwolfson
added a commit
that referenced
this pull request
Oct 6, 2026
…(2026-10-05) (#433) * docs(issues): fold in the Egeria team's response and our corrections (2026-10-05) The Egeria team answered the open server-bug list (source oak2026 fb3d6fce53; fixes are in two unmerged PRs, so no build has them, and nothing was tested live). Recorded per entry: 90, 112, 117, 124, 125 valid with fixes pending merge; 102 and 108 not reproduced by them; 95 and 85 confirmed. Corrections to our own entries: ISSUE-125's cause was an argument-order bug at OMRSRepositoryContentValidator:877, not a GUID map (our hypothesis was wrong, confirmed in source); ISSUE-89's claim that rsa.key-id stops key regeneration was wrong (RSAGenerator always generates a new pair); ISSUE-79 is probably a pyegeria bug, since deep_copy defaulted to False until #399 (2026-09-29) and the folder helper never set it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com> * docs(issues): ISSUE-122 is fixed and released (#421, 6.1.28), not pending The entry still said 'fixed on branch ..., pending PR/merge'; that branch merged in #421 and shipped in 6.1.28 (and 6.1.29). Re-verified read-only on the 2026-10-05 rebuilt platform: get_catalog_targets returns 'No elements found' in all three formats with no server error. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com> --------- Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com> Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AssetMaker.get_catalog_target/get_catalog_targetssentmetadataElementTypeName="CatalogTarget"(a relationship type), which the server rejects withOMAG-COMMON-400-019._async_get_guid_requestgainsfilter_results_by_type(defaultTrue, mirroring_async_get_results_body_request); both methods now passFalse.get_catalog_targetDICT/MD output was an all-blank record because the endpoint returns a relationship, not an element. Added_generate_catalog_target_output; the relationship's ends are element stubs (guid/uniqueName/type), so names come fromuniqueName.CatalogTargetPropertiesgainsconnectionName,metadataCollectionQualifiedName,permittedSynchronization,deleteMethod(previously dropped silently byextra='ignore').test_lists_own_subscriptionsassumedEGERIA_USERwas unset (screen falls back togarygeeke); it now pins the user, so it passes on machines with anotherEGERIA_USER.PYEGERIA_ISSUES.md, marked fixed pending this PR.Test plan
test_asset_maker_catalog_targets.py), including the real response shape captured livetests/micro-testspasses locally (also withEGERIA_USERset to a different user, and unset)scripts/omvs_audit.py --service asset-maker: no catalog-target findings (one unrelated pre-existingunassign_actionPATH mismatch)🤖 Generated with Claude Code