Repository navigation
My profile fixes - #412
Merged
Merged
My profile fixes#412
Conversation
dwolfson
approved these changes
Oct 2, 2026
Rebased onto main after odpi#413 (which added its own bookmarks implementation), reconciling the two: - Bookmarks keep odpi#412's structure (BookmarksMixin in bookmarks_handler.py, Ctrl+K / 'k' to bookmark the highlighted row, in-place reload, 'd' to remove) and its tests, with odpi#413's storage: the collection is Bookmarks::<user id>, anchored to the user's profile and linked from it by a ResourceList relationship (resourceUse "Bookmarks"), so MyProfile.get_my_resources() finds it and existing odpi#413 bookmarks are kept. Adding an existing bookmark now warns instead of duplicating it. - Ctrl+B (main and Shop for Data) still opens the bookmarks screen with the highlighted row's GUID pre-filled; get_row_guid moves into the mixin and uses row_identity. - odpi#413's bookmark methods in my_profile_app.py are removed in favour of the mixin. The manual keeps odpi#412's rewrite, with the bookmarks section updated; the developer guide's bookmarks passages and screenshots are updated to match. Signed-off-by: Peter Coldicott <86156876+pcoldico@users.noreply.github.com>
pcoldico
force-pushed
the
my-profile-fixes
branch
from
October 2, 2026 16:37
6c931e5 to
d15a841
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My Profile: rebuild the Add screens on a shared base class; fix Change User, the status screens and broken key bindings; add bookmarks (a personal collection, Ctrl+K on any row), My Collections, a Projects panel, a Subscriptions list, subscriptions linked to items, governance action processes, and joining teams; update the user manual and reference guide. Depends on #<PR 1>. 284 My Profile tests pass against fakes; not yet run against a live Egeria server.