Repository navigation
fix(sdk): send the name as filter_string in three get_*_by_name methods - #398
Merged
Merged
Conversation
SchemaMaker.get_schema_types_by_name, SchemaMaker.get_schema_attributes_by_name and DataDiscovery.get_analysis_reports_by_name passed the name to _async_get_name_request as name=, but the helper's parameter is filter_string. The name fell into **kwargs and the request went out with a null filter, so Egeria rejected every call (OPEN-METADATA-400-004 "The name passed on the name parameter of the getSchemaTypesByName operation is null"). Found live while cleaning up after verifying Link Schema Type Definition; the fixed get_schema_types_by_name was then used to find and delete the test schema type. Signed-off-by: Dan Wolfson <dan.wolfson@pdr-associates.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SchemaMaker.get_schema_types_by_name,SchemaMaker.get_schema_attributes_by_nameandDataDiscovery.get_analysis_reports_by_namepassed the name to_async_get_name_requestasname=, but the helper's parameter isfilter_string. The name fell into**kwargs, so the request went out with a null filter and Egeria rejected every call:The fix changes
name=nametofilter_string=namein each of the three calls.Test plan
tests/micro-tests/test_get_by_name_filter_string.pycovers all three methods. It fails without the fix and passes with it.get_schema_types_by_namefound a test schema type by qualified name on a local Egeria server, where the unfixed version raised the error above.🤖 Generated with Claude Code