Skip to content

fix: update entrypoint path in C2DEngineDocker class - #1492

Merged
AdriGeorge merged 1 commit into
mainfrom
feat/algo-path
Oct 6, 2026
Merged

AdriGeorge merged 1 commit into
mainfrom
feat/algo-path

Conversation

@AdriGeorge

Copy link
Copy Markdown
Collaborator

New bug: $ALGO resolves to a relative path in the docker engine

  • compute_engine_docker.ts replaces $ALGO in the entrypoint with data/transformations/algorithm, without a leading slash
  • No WorkingDir is set on the container, so the image's own WORKDIR applies
  • Result: any image with WORKDIR other than / breaks with python $ALGO. Example: WORKDIR /app makes it look for /app/data/transformations/algorithm
  • Fix suggestion: replace with /data/transformations/algorithm (absolute)
    Workaround for now: use the absolute path in the entrypoint instead of $ALGO

@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 27 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 37e38994-f5bc-47fe-a619-e11454d7b025
📥 Commits

Reviewing files that changed from the base of the PR and between ca161f2 and bf07577.

📒 Files selected for processing (1)
  • src/components/c2d/compute_engine_docker.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@AdriGeorge
AdriGeorge merged commit ecd49a9 into main Oct 6, 2026
10 checks passed
@AdriGeorge
AdriGeorge deleted the feat/algo-path branch October 6, 2026 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants