Skip to content

Add order for templates - #1490

Merged
giurgiur99 merged 1 commit into
mainfrom
feature/template-order
Oct 6, 2026
Merged

giurgiur99 merged 1 commit into
mainfrom
feature/template-order

Conversation

@giurgiur99

@giurgiur99 giurgiur99 commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Fixes # .

Changes proposed in this PR:

Summary by CodeRabbit

  • New Features
    • Service catalogue entries can now have an optional integer order, allowing entries to be listed from lowest order to highest. Entries without an order follow in their existing sequence.

@coderabbitai

coderabbitai Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 241f6ddb-2349-4b36-ab6c-be7fc9b19ff2
📥 Commits

Reviewing files that changed from the base of the PR and between 870a211 and eacfd77.

📒 Files selected for processing (2)
  • src/@types/C2D/ServiceOnDemand.ts
  • src/utils/config/schemas.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The service template type and configuration schema now include an optional integer order field. The field documentation specifies that lower values come first and entries without a value follow in node order.

Changes

Catalogue order field

Layer / File(s) Summary
Define the catalogue order field
src/@types/C2D/ServiceOnDemand.ts, src/utils/config/schemas.ts
ServiceTemplate adds optional order, and ServiceTemplateSchema accepts an optional integer order. Both describe the catalogue ordering semantics.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to eacfd

No actionable merge-blocking issue is established. Catalogue display ordering depends on how its client uses the new metadata.

Security Architecture Review

Security architecture risk: 🔵 Low · up to eacfd

The change adds validated catalogue metadata without changing the inspected template-loading or secret-filtering behavior. No introduced security issue was identified. Compatibility with older validators and downstream clients remains unverified.

Retained concerns
No architecture-level concerns identified.

Security review details

Security Blast Radius

  • inferred — On the inspected path, influence over order requires control of a template file read from the configured directory. Its demonstrated effect is publication of an integer in that node's catalogue response, not changed duplicate identity or server-side template ordering. Broader client interpretation and remote write access were not established.

Trust Boundaries and Controls

  • observed — The schema explicitly admits only an optional integer for order while retaining strict unknown-field rejection and existing template refinements. The inspected refinements do not use order to modify image-mode or command-source constraints.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding an order field for templates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@giurgiur99
giurgiur99 merged commit ca161f2 into main Oct 6, 2026
10 checks passed
@giurgiur99
giurgiur99 deleted the feature/template-order branch October 6, 2026 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants