Add ovary-other NTR template and reports - #3739
Open
zhengj2007 wants to merge 1 commit into
Open
Conversation
Generated from ovary-other source data via Stage 1-4 bulk NTR workflow.\n\nSigned-off-by: @dragon-ai-agent
Contributor
|
Claude encountered an error after 1s —— View job I'll analyze this and get back to you. |
5 tasks
cmungall
pushed a commit
that referenced
this pull request
Aug 22, 2026
UBERON:9900001 was claimed by seven other open PRs (#3622, #3623, #3693, #3698, #3699, #3700, #3739) and UBERON:9900002 by four of them. Every NTR branch mints from the bottom of the 9900000-10000000 "Temporary IDs" block in uberon-idranges.owl, so they all pile onto the same first few numbers. The range holds 100,000 IDs and nothing above 9900112 is claimed by any open PR, so the collision is avoidable now rather than only at minting time. Moved to 9903758/9903759, derived from this PR's number so the allocation is traceable and far from the bottom of the block where the next NTR run will land. These are still temporary IDs and still need minting from a real allocated range before merge; this only stops the branch colliding with its neighbours in the meantime. Re-normalised with robot convert; roundtrip_obo clean. Signed-off-by: @ai4c-agent
Contributor
|
This PR has not seen any activity in the past month; if nobody comments or reviews it in the next week, the PR creator will be allowed to proceed with merging without explicit approval, should they wish to do so. |
cmungall
added a commit
that referenced
this pull request
Aug 27, 2026
* Add terms for skull and calvarial bone marrow
Motivated by a review of Park et al. (2026) "Functional role of skull
lymphoid structures in CNS immunosurveillance", Nature,
doi:10.1038/s41586-026-10951-4.
UBERON had no representation of skull/calvarial bone marrow at all, even
though this compartment has been an active subject of neuroimmunology
since 2018 (Herisson et al. 2018, PMID:30150661; Cugurra et al. 2021,
PMID:34083447; Mazzitelli et al. 2022, PMID:35301477) and is the subject
of the Park et al. paper. The only bone-marrow-by-site terms present were
'red bone marrow of sternum' (UBERON:8410080) and 'red bone marrow of
iliac crest'; this made it impossible to annotate the growing body of
scRNA-seq and imaging data that contrasts skull marrow with other marrow
sites.
Two new terms, following the existing bone-marrow-by-site pattern:
- UBERON:9900001 'bone marrow of skull'
bone marrow and part_of some skull (UBERON:0003129)
syn: skull bone marrow, cranial bone marrow, skull BM
- UBERON:9900002 'bone marrow of calvaria'
bone marrow of skull and part_of some vault of skull (UBERON:0004339)
syn: calvarial bone marrow, calvarial marrow
'bone marrow of calvaria' is defined relative to 'bone marrow of skull'
rather than to 'bone marrow' directly, because UBERON does not assert
cranium part_of skull (only skull has_part cranium), so the subsumption
would not otherwise be entailed.
All definition xrefs are verified PMIDs. Note that the Park et al. paper
is not yet indexed in PubMed/Europe PMC, so it is cited by DOI in the
term comments rather than as a definition xref; the DOI should be
replaced with a PMID once one is assigned.
IDs are in the temporary UBERON:99xxxxx range per CLAUDE.md and need to
be minted properly before merge.
Signed-off-by: @ai4c-agent
* Add terminology note distinguishing skull vs calvarial marrow
The author-supplied PDF of Park et al. includes Extended Data Fig. 1b,
which is not in the version I read from nature.com. Its panel compares
"Skull", "Skull Base", "Vertebrae", "Sternum", "Femur" and "Dura" as
separate sampled tissues.
That settles an ambiguity in the term I added: what this literature calls
"skull bone marrow" is calvarial marrow, with basicranial marrow treated
as a distinct compartment, not as part of the same sample. Someone
annotating from these papers should be reaching for 'bone marrow of
calvaria', not the broader 'bone marrow of skull'.
Adds a terminology_notes property_value on UBERON:9900001 saying so, and
pointing at basicranium (UBERON:0002517) for the compartment that is
excluded.
Signed-off-by: @ai4c-agent
* Drop created_by, and normalise to fix roundtrip_obo
Two changes, both to the two new bone marrow stanzas.
Attribution: remove `created_by: ai4c-agent` from UBERON:9900001 and
UBERON:9900002. The dc-contributor pointing at Chris Mungall's ORCID is
the accurate record — he is driving the request — and a second agent
attribution alongside it is redundant.
Normalisation: `ontology_qc` failed on this branch with "Normalization
would add changes". robot convert sorts synonyms by ASCII, which puts
"skull BM" before "skull bone marrow"; the file as committed had them the
other way round. Ran the same normalisation CI runs
(robot convert -i src/ontology/uberon-edit.obo -o NORMALIZE.obo) and
applied the result. Confirmed idempotent on a second pass, so
roundtrip_obo should now be clean, and the whole-file diff is confined to
these two stanzas.
Signed-off-by: @ai4c-agent
* Renumber to UBERON:9903758/9903759 to clear PR ID collisions
UBERON:9900001 was claimed by seven other open PRs (#3622, #3623, #3693,
#3698, #3699, #3700, #3739) and UBERON:9900002 by four of them. Every NTR
branch mints from the bottom of the 9900000-10000000 "Temporary IDs" block
in uberon-idranges.owl, so they all pile onto the same first few numbers.
The range holds 100,000 IDs and nothing above 9900112 is claimed by any
open PR, so the collision is avoidable now rather than only at minting
time. Moved to 9903758/9903759, derived from this PR's number so the
allocation is traceable and far from the bottom of the block where the
next NTR run will land.
These are still temporary IDs and still need minting from a real allocated
range before merge; this only stops the branch colliding with its
neighbours in the meantime.
Re-normalised with robot convert; roundtrip_obo clean.
Signed-off-by: @ai4c-agent
* Add SNOMED xref and PMID:42618784; record FMA situation
Both corrections come from checking things I had asserted too loosely.
PMID. I had said the paper was not yet indexed and cited it by DOI. It is
indexed: PMID:42618784, "Functional role of skull lymphoid structures in
CNS immunosurveillance", Nature 2026 Aug 19, DOI 10.1038/s41586-026-10951-4,
first author Park JH. Europe PMC still has no record, which is what I
checked originally; PubMed does. Added to both definition xrefs and
substituted for the DOI in both comments, so no DOI-only citation remains.
SNOMED xref. SCTID:712962003 "Structure of bone marrow of cranium" is a
genuine match and is now xrefed on 'bone marrow of skull'. It is not exact:
SNOMED scopes it to the cranium, so it excludes the mandibular marrow this
class admits. Its parent SCTID:421320006 is already xrefed on 'bone marrow',
and its children cover frontal, temporal, sphenoid and nasal-orbit marrow.
Recorded in external_ontology_notes rather than left implicit.
FMA. There is no FMA xref to add, but not for the reason I gave. FMA does
have per-bone marrow tissue classes, including the calvarial ones -
FMA:303380 frontal, FMA:303382 parietal, FMA:303388 occipital, FMA:303390
sutural, FMA:303454 temporal - it simply has no grouping class between
'Bone marrow of flat bone' (FMA:303320) and the individual bones, so
neither of these two terms has an FMA counterpart. Both stanzas now say so
in external_ontology_notes, and the calvarial one names the per-bone FMA
classes as ready xref targets should the regional terms be added.
(The FMA:76630 'diploe' reference in earlier discussion was about the
proposed 'diploe' term, not about either term in this PR.)
Re-normalised with robot convert; roundtrip_obo clean and idempotent.
Signed-off-by: @ai4c-agent
* Address review: term_tracker_item and calvaria/vault caveat
Both from ai4c-reviewer's suggestions on PR #3758.
term_tracker_item: neither stanza had one. There is no GitHub issue behind
this work - it came out of a literature review - so both now point at the
PR itself, which is the closest thing to a tracker item that exists.
Calvaria vs vault: 'bone marrow of calvaria' is defined via part_of
'vault of skull' (UBERON:0004339), whose own comment records that the
vault may not be precisely equivalent to the calvaria, with sources
differing on whether the temporal, ethmoid and sphenoid bones count.
Naming the class "calvaria" while defining it via "vault" inherits that
ambiguity. Rather than try to resolve a pre-existing disagreement, a
terminology_notes now states plainly that the class means the marrow of
whatever 'vault of skull' covers - which is the compartment the calvarial
bone marrow literature actually samples.
Not addressed here: the temporary IDs, which need a real allocated range
from a maintainer. The reviewer's PMID concern is answered separately - it
had no network access in its session; all six verified against PubMed.
Re-normalised with robot convert; clean and idempotent.
Signed-off-by: @ai4c-agent
* Move terms into the Automation ID range (UBERON:1200342/1200343)
These should never have been in the temporary block. uberon-idranges.owl
allocates idrange:44, 1200000-1300000, to "Automation" - and that range is
in real use, with seven merged terms already in it (UBERON:1200000 through
1200341, contributed by Mungall, Puig-Barbe and others). The 9900000-10000000
"Temporary IDs" block, by contrast, contains nothing merged at all; it is
scratch space that open NTR branches all mint from and that never survives
to master.
So the two terms move to the next free Automation IDs:
UBERON:9903758 -> UBERON:1200342 bone marrow of skull
UBERON:9903759 -> UBERON:1200343 bone marrow of calvaria
Verified unused anywhere in the repo before taking them, and no open PR
claims anything in 12xxxxx.
I originally used 99xxxxx because CLAUDE.md line 54 says "New terms start
UBERON:99xxxxx". That instruction points at the temporary block rather than
the Automation range and is worth revisiting, since it will send every
future agent run to the same place.
The diff is larger than the two-line change suggests only because robot
sorts stanzas by ID: renumbering relocates both stanzas from the end of the
term section to their sorted position after UBERON:1200341. Two ids added,
two removed, nothing else altered.
Re-normalised with robot convert; clean and idempotent.
Signed-off-by: @ai4c-agent
---------
Signed-off-by: @ai4c-agent
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated from ovary-other source data via Stage 1-4 bulk NTR workflow.
Signed-off-by: @dragon-ai-agent