Apply endAngle as documented and add unfilledStrokeCap prop - #273
Open
jcbkdev wants to merge 2 commits into
Open
Apply endAngle as documented and add unfilledStrokeCap prop#273jcbkdev wants to merge 2 commits into
endAngle as documented and add unfilledStrokeCap prop#273jcbkdev wants to merge 2 commits into
Conversation
jcbkdev
changed the title
endAngle as documented, not just to spinner arcendAngle as documented and add unfilledStrokeCap prop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
endAnglewas documented as controlling the sweep of the whole circle, but it was only used on the spinner's border arc. AppliedCIRCLE * endAngleto the progress and unfilled arcs to match the docs.Also changed the default from
0.9to1because now it'd silently give every default circle a gap for no reason.Added
unfilledStrokeCaptoCircleso the unfilled arc's stroke cap can be styled independently of the progress arc.Before
After
unfilledStrokeCap