fix: update depreacted actions - #24
Open
rahulfoc1990 wants to merge 5 commits into
Open
Conversation
Sonarqube integration with project
update sonarqube workflow
jsconan
reviewed
Sep 6, 2024
jsconan
left a comment
jsconan
left a comment
Collaborator
There was a problem hiding this comment.
It looks good for the essential.
However, the PR was targeting master, which was not correct. I rebased it to develop, but the actions did not trigger and I cannot make sure they pass well
BTW, as a side note we should not have OAT specific CI on a forked repository. It will prevent us to contribute to the base repo without polluting them. This one is an exception, because we introduced very specific features that cannot be proposed to the base repo, so it would be fine. But, we need to keep this in mind when managing a forked repo.
jsconan
approved these changes
Sep 6, 2024
jsconan
left a comment
jsconan
left a comment
Collaborator
There was a problem hiding this comment.
The action did not trigger, but looking at the changes, it would be ok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.