Skip to content

Pro review comment: point to the status check for the review state - #222

Merged
reuvenharrison merged 1 commit into
mainfrom
pro-comment-no-stale-status
Nov 15, 2026
Merged

reuvenharrison merged 1 commit into
mainfrom
pro-comment-no-stale-status

Conversation

@reuvenharrison

Copy link
Copy Markdown
Contributor

With an oasdiff-token, the comment carried a line with the state of the review: "Review required", "All changes approved" or "Changes requested". The comment is only written when the job runs, so after a reviewer approved the changes the line still said "Review required". With the GitHub App installed the oasdiff status check turns green at that moment and the pull request can merge with no further run, which left a merged pull request saying its review was pending.

The line no longer states a state:

Approve or reject each breaking change in the review. The oasdiff status check on this pull request shows whether they are all approved.

The status check is unchanged. The footer now says to make it a required check to block merging until every breaking change is approved.

🤖 Generated with Claude Code

The comment is written when the job runs, so a line saying the review is
pending stayed in place after the changes were approved, including on a merged
pull request. The comment now says where to approve and that the oasdiff
status check shows whether the changes are all approved.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@reuvenharrison
reuvenharrison merged commit a0f9352 into main Nov 15, 2026
47 checks passed
@reuvenharrison
reuvenharrison deleted the pro-comment-no-stale-status branch November 15, 2026 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant