Repository navigation
Pro review comment: point to the status check for the review state - #222
Merged
Merged
Conversation
The comment is written when the job runs, so a line saying the review is pending stayed in place after the changes were approved, including on a merged pull request. The comment now says where to approve and that the oasdiff status check shows whether the changes are all approved. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With an
oasdiff-token, the comment carried a line with the state of the review: "Review required", "All changes approved" or "Changes requested". The comment is only written when the job runs, so after a reviewer approved the changes the line still said "Review required". With the GitHub App installed theoasdiffstatus check turns green at that moment and the pull request can merge with no further run, which left a merged pull request saying its review was pending.The line no longer states a state:
The status check is unchanged. The footer now says to make it a required check to block merging until every breaking change is approved.
🤖 Generated with Claude Code