Repository navigation
Let an approved Pro review satisfy fail-on - #220
Merged
Merged
Conversation
The job's exit code came from fail-on alone, so a workflow that set fail-on and added an oasdiff-token stayed red after every breaking change was approved. Where that job is a required check, approval could never unblock the merge. With a token, fail-on of ERR or WARN is now satisfied once the review is approved. While it is pending or rejected the job fails as before, with a notice saying how to clear it, so a required job still blocks. INFO and MISSING-VERSION-BUMP are not cleared by approval, and nothing changes when no review could be posted. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#216 put the Pro token on
breaking, where most workflows also setfail-on. The two did not work together: the job's exit code came fromfail-onalone, so the job stayed red after every breaking change was approved. Where that job is a required check, approval could never unblock the merge.With an
oasdiff-token:fail-on: ERRorWARNSo a job that is a required check keeps blocking until the changes are approved, and adding the token to an existing workflow does not loosen it.
Not cleared by approval:
fail-on: INFO(info changes are not part of the review's gate) andMISSING-VERSION-BUMP, from the input or from.oasdiff.yaml(a missing version bump is a rule about the release). Nothing changes when no review could be posted, for example an expired plan, or when no token is set.The test stubs the three cases: pending fails with the notice, approved passes, approved with
MISSING-VERSION-BUMPstill fails.🤖 Generated with Claude Code