Skip to content

Let an approved Pro review satisfy fail-on - #220

Merged
reuvenharrison merged 1 commit into
mainfrom
pro-approval-clears-fail-on
Nov 15, 2026
Merged

reuvenharrison merged 1 commit into
mainfrom
pro-approval-clears-fail-on

Conversation

@reuvenharrison

Copy link
Copy Markdown
Contributor

#216 put the Pro token on breaking, where most workflows also set fail-on. The two did not work together: the job's exit code came from fail-on alone, so the job stayed red after every breaking change was approved. Where that job is a required check, approval could never unblock the merge.

With an oasdiff-token:

review fail-on: ERR or WARN
pending or rejected the job fails, as it does without a token, and a notice says to approve the changes and re-run
approved the job passes

So a job that is a required check keeps blocking until the changes are approved, and adding the token to an existing workflow does not loosen it.

Not cleared by approval: fail-on: INFO (info changes are not part of the review's gate) and MISSING-VERSION-BUMP, from the input or from .oasdiff.yaml (a missing version bump is a rule about the release). Nothing changes when no review could be posted, for example an expired plan, or when no token is set.

The test stubs the three cases: pending fails with the notice, approved passes, approved with MISSING-VERSION-BUMP still fails.

🤖 Generated with Claude Code

The job's exit code came from fail-on alone, so a workflow that set
fail-on and added an oasdiff-token stayed red after every breaking change
was approved. Where that job is a required check, approval could never
unblock the merge.

With a token, fail-on of ERR or WARN is now satisfied once the review is
approved. While it is pending or rejected the job fails as before, with a
notice saying how to clear it, so a required job still blocks. INFO and
MISSING-VERSION-BUMP are not cleared by approval, and nothing changes when
no review could be posted.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@reuvenharrison
reuvenharrison merged commit 0546e2e into main Nov 15, 2026
47 checks passed
@reuvenharrison
reuvenharrison deleted the pro-approval-clears-fail-on branch November 15, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant