Repository navigation
auth: name the callback address for the mobile OIDC sign-in - #504
Merged
vikramsoni2 merged 1 commit intoOct 27, 2026
Merged
Conversation
Since 0f5344d the OIDC middleware mounts its callback route by hand (routes.callback: false), so express-openid-connect no longer adds a redirect_uri to the authorization request. /login and /oidc/login were given one explicitly; /oidc/mobile/login (nxzai#371) was not, and providers such as pocket-id now refuse the native app's sign-in with "redirect_uri is required". Both login routes now share one helper that names the configured callback address, and the mobile route passes it too. A provider-flow test through the real library pins it, alongside the existing web case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 0f5344d the OIDC middleware mounts its callback route by hand (routes.callback: false), so express-openid-connect no longer adds a redirect_uri to the authorization request. /login and /oidc/login were given one explicitly; /oidc/mobile/login (#371) was not, and providers such as pocket-id now refuse the native app's sign-in with "redirect_uri is required".
Both login routes now share one helper that names the configured callback address, and the mobile route passes it too. A provider-flow test through the real library pins it, alongside the existing web case.