Switch from lua_ls to emmylua_ls - #2163
Open
oriori1703 wants to merge 2 commits into
Open
oriori1703 wants to merge 2 commits into
oriori1703 wants to merge 2 commits into
Conversation
Collaborator
Author
|
BTW, I also open a PR to add type hints for emmylua's lsp settings. |
|
Is there a reason for not merging this? Whats the holdup? |
Collaborator
Author
Mainly because I'm looking for feedback (positive or negative), and because I'm on vacation and don't have the time right now :) |
lan1812783
reviewed
Sep 29, 2026
| -- NOTE: this is a lot slower and will cause issues when working on your own configuration. | ||
| -- See https://github.com/neovim/nvim-lspconfig/issues/3189 | ||
| library = vim.api.nvim_get_runtime_file('', true), | ||
| format = { enable = false }, -- Disable formatting (formatting is done by stylua) |
There was a problem hiding this comment.
It seems that emmylua_ls does not provide an option to disable its formatting capability.
See:
There was a problem hiding this comment.
According to this https://github.com/EmmyLuaLs/emmylua-analyzer-rust/blob/main/docs/external_format/external_formatter_options_EN.md you can use external formatter by making emmyrc.json file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently neovim maintainers switched from lua_ls to emmylua for the neovim/neovim repo (neovim/neovim#41750).
I thought this was probably a good time to try to switch to emmylua in kickstart.
I'm going to test this for bit before making a descision.
I would greatly appreciate if other people could check this out and report on their experience :)
related to #2147
closes: #1975