Skip to content

chore(deps): upgrade TypeScript 5 → 6 - #805

Closed
bisakodyl wants to merge 1 commit into
nuxt:mainfrom
bisakodyl:greenpr/typescript-4-7
Closed

bisakodyl wants to merge 1 commit into
nuxt:mainfrom
bisakodyl:greenpr/typescript-4-7

Conversation

@bisakodyl

Copy link
Copy Markdown

Addresses #801

This pull request moves the project from TypeScript 5.9 to TypeScript 6.0.3 by updating the devDependency, the pnpm workspace override and the peer dependency range (^5.9.3 || ^6.0.0), and by making the new TypeScript 6 compiler defaults explicit in tsconfig.json. TypeScript 7 was attempted and reverted, because vue-tsc 3.3.x and @arethetypeswrong/core 0.18.5 require the TypeScript JS API, which 7.0 does not ship. Type checking, the tsdown build (including attw and publint) and all 11 vitest tests pass on TypeScript 6. Reviewers should note three things: libReplacement is set to the new default false rather than the previous true; the regenerated lockfile also bumps the pinned Node runtime to 24.22.1, which is unrelated and should ideally be reverted; and pnpm lint was not run.

Note: this touches files also modified in #772 (v1.0.4), #794 (chore(deps): update all non-major dependencies), #799 (chore(deps): lock file maintenance), #803 (chore(deps): update nuxt framework to ~4.6.2), #804 (chore(deps): update peerdependency @nuxt/cli to v4); this PR is based on current main and is independent of them.

What was verified

Check Before After
Tests (pnpm test) 11 passed (11) (exit 0) 11 passed (11) (exit 0)
Build exit 0 exit 0
Type check exit 0 exit 0
  • Static integrity checks (L1): no findings.
  • Test files changed: none.
  • Independent model review (L2): mergeable, confidence 0.74; 0 blocking, 5 warnings, 2 info.

Behavior changes

  • The typescript peer dependency range is widened from ^5.9.3 to ^5.9.3 || ^6.0.0, so consumers can now install the package alongside TypeScript 6 without peer warnings.
  • The development toolchain now compiles and type-checks with TypeScript 6.0.3 instead of 5.9.x (devDependency and pnpm workspace override).
  • The lockfile's pinned Node.js runtime moved from 24.21.0 to 24.22.1 as a side effect of regenerating the lockfile.
  • The published JS and declaration output is reported to be identical apart from content-hash filenames and the embedded package.json TypeScript ranges.
  • No runtime API, CLI behaviour or emitted type changes were found beyond the above.

Test changes

No test files were changed. The only verification-related file touched is tsconfig.json. In it, the new TypeScript 6 defaults (types, rootDir, noUncheckedSideEffectImports, libReplacement) were set explicitly. None of these loosens checking: types: ["node"] narrows globals, and noUncheckedSideEffectImports: false keeps the previous behaviour. libReplacement: false matches the new default rather than the old one, which only matters if @typescript/lib-* packages are installed. All 11 tests pass before and after the change. Lint was not run.


Prepared by GreenPR (experimental). Human review required. Not auto-merged.

This pull request moves the project from TypeScript 5.9 to TypeScript 6.0.3 by updating the devDependency, the pnpm workspace override and the peer dependency range (`^5.9.3 || ^6.0.0`), and by making the new TypeScript 6 compiler defaults explicit in tsconfig.json. TypeScript 7 was attempted and reverted, because `vue-tsc` 3.3.x and `@arethetypeswrong/core` 0.18.5 require the TypeScript JS API, which 7.0 does not ship. The pair policy allows stopping at version 6 for this reason. Type checking, the tsdown build (including attw and publint) and all 11 vitest tests pass on TypeScript 6. Reviewers should note three things: `libReplacement` is set to the new default `false` rather than the previous `true`; the regenerated lockfile also bumps the pinned Node runtime to 24.22.1, which is unrelated and should ideally be reverted; and `pnpm lint` was not run.
@bisakodyl
bisakodyl requested a review from danielroe as a code owner October 22, 2026 11:56
@github-actions

Copy link
Copy Markdown
Contributor

Mixed activity

Activity patterns show a mix of organic and automated signals.

View full analysis →

Evidence
  • Multiple forks: 6 repositories forked in a single 24-hour window

This is an automated analysis by AgentScan

@github-actions

Copy link
Copy Markdown
Contributor

We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:

  1. Never let an LLM speak for you - all comments, issues, and PR descriptions should be written in your own words, reflecting your own understanding.
  2. Never let an LLM think for you - only submit contributions you fully understand and can explain.

Please review these AI-assisted contribution guidelines and update this contribution if needed.

If this was flagged in error, we apologise! 😳 Just let us know. 🙏

@pkg-pr-new

pkg-pr-new Bot commented Oct 22, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/module-builder@805

commit: 3b4eec7

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedtypescript@​5.9.3 ⏵ 6.0.3100 +110090 +110090

View full report

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 31f76be3-72a8-4e8e-adbc-132cb0b22807
📥 Commits

Reviewing files that changed from the base of the PR and between e88f36d and 3b4eec7.

⛔ Files ignored due to path filters: 1
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing: 3
  • package.json
  • pnpm-workspace.yaml
  • tsconfig.json

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.

📝 Walkthrough

The TypeScript peer dependency range now includes ^6.0.0. The development dependency and workspace override now use ^6.0.0. The TypeScript configuration adds Node types and ./src as the root directory, and sets noUncheckedSideEffectImports and libReplacement to false.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Merge Risk: ⚪ Minimal · up to 3b4ee

No actionable merge-blocking risk remains from the reviewed changes.

Pre-merge checks: Passed 5
Check name Status Explanation
Description check Passed The description clearly explains the TypeScript 6 upgrade, related configuration changes, verification results, and known limitations.
Title check Passed The title clearly and concisely identifies the main change: upgrading TypeScript from version 5 to version 6.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bisakodyl

Copy link
Copy Markdown
Author

Closing this: unbuild doesn't support TypeScript 6 yet, so widening the peer range can't pass test:engines today. I'm testing a migration tool and the description was generated with it — sorry for the noise, and thanks for the clear contribution rules.

@bisakodyl bisakodyl closed this Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant