Repository navigation
Conversation
This pull request moves the project from TypeScript 5.9 to TypeScript 6.0.3 by updating the devDependency, the pnpm workspace override and the peer dependency range (`^5.9.3 || ^6.0.0`), and by making the new TypeScript 6 compiler defaults explicit in tsconfig.json. TypeScript 7 was attempted and reverted, because `vue-tsc` 3.3.x and `@arethetypeswrong/core` 0.18.5 require the TypeScript JS API, which 7.0 does not ship. The pair policy allows stopping at version 6 for this reason. Type checking, the tsdown build (including attw and publint) and all 11 vitest tests pass on TypeScript 6. Reviewers should note three things: `libReplacement` is set to the new default `false` rather than the previous `true`; the regenerated lockfile also bumps the pinned Node runtime to 24.22.1, which is unrelated and should ideally be reverted; and `pnpm lint` was not run.
Mixed activityActivity patterns show a mix of organic and automated signals. Evidence
This is an automated analysis by AgentScan |
|
We've flagged this as a potential contribution without a human behind it. We welcome the thoughtful use of AI tools when contributing, but ask all contributors to follow two core principles:
Please review these AI-assisted contribution guidelines and update this contribution if needed. If this was flagged in error, we apologise! 😳 Just let us know. 🙏 |
commit: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
Closing this: unbuild doesn't support TypeScript 6 yet, so widening the peer range can't pass test:engines today. I'm testing a migration tool and the description was generated with it — sorry for the noise, and thanks for the clear contribution rules. |
Addresses #801
This pull request moves the project from TypeScript 5.9 to TypeScript 6.0.3 by updating the devDependency, the pnpm workspace override and the peer dependency range (
^5.9.3 || ^6.0.0), and by making the new TypeScript 6 compiler defaults explicit in tsconfig.json. TypeScript 7 was attempted and reverted, becausevue-tsc3.3.x and@arethetypeswrong/core0.18.5 require the TypeScript JS API, which 7.0 does not ship. Type checking, the tsdown build (including attw and publint) and all 11 vitest tests pass on TypeScript 6. Reviewers should note three things:libReplacementis set to the new defaultfalserather than the previoustrue; the regenerated lockfile also bumps the pinned Node runtime to 24.22.1, which is unrelated and should ideally be reverted; andpnpm lintwas not run.Note: this touches files also modified in #772 (v1.0.4), #794 (chore(deps): update all non-major dependencies), #799 (chore(deps): lock file maintenance), #803 (chore(deps): update nuxt framework to ~4.6.2), #804 (chore(deps): update peerdependency @nuxt/cli to v4); this PR is based on current
mainand is independent of them.What was verified
pnpm test)Behavior changes
typescriptpeer dependency range is widened from^5.9.3to^5.9.3 || ^6.0.0, so consumers can now install the package alongside TypeScript 6 without peer warnings.Test changes
No test files were changed. The only verification-related file touched is tsconfig.json. In it, the new TypeScript 6 defaults (
types,rootDir,noUncheckedSideEffectImports,libReplacement) were set explicitly. None of these loosens checking:types: ["node"]narrows globals, andnoUncheckedSideEffectImports: falsekeeps the previous behaviour.libReplacement: falsematches the new default rather than the old one, which only matters if@typescript/lib-*packages are installed. All 11 tests pass before and after the change. Lint was not run.Prepared by GreenPR (experimental). Human review required. Not auto-merged.