Skip to content

fix(ecosystem): inherit the root pnpm version in the Nuxt 4/5 playgrounds - #1138

Merged
antfu merged 1 commit into
mainfrom
fix/ecosystem-playground-pnpm-pin
Oct 27, 2026
Merged

antfu merged 1 commit into
mainfrom
fix/ecosystem-playground-pnpm-pin

Conversation

@antfubot

Copy link
Copy Markdown
Collaborator

The nuxt4-smoke job (and the Nuxt 4/5 steps of ecosystem-playground) has failed since the root bumped to pnpm@12.15.0 in 6ea436d: the sealed playgrounds still pinned pnpm@12.14.0, and under corepack pnpm refuses the mismatch with ERR_PNPM_BAD_PM_VERSION.

This is the second time the pins drifted (see #1129). Dropping packageManager from the two playgrounds lets them inherit the root's version, the same way playgrounds-ecosystem/modules already does, so future pnpm bumps can't break them.


This PR was created with the help of an AI agent.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying nuxt-devtools with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8ee5929
Status: ✅  Deploy successful!
Preview URL: https://b92a6166.nuxt-devtools.pages.dev
Branch Preview URL: https://fix-ecosystem-playground-pnp.nuxt-devtools.pages.dev

View logs

@coderabbitai

coderabbitai Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 706f3e32-b14f-4430-b1ce-c76b6770ab3a
Commits

Reviewing files that changed from the base of the PR and between b73714b and 8ee5929.

Files selected for processing: 2
  • playgrounds-ecosystem/nuxt4/package.json
  • playgrounds-ecosystem/nuxt5/package.json
Files with no reviewable changes: 2
  • playgrounds-ecosystem/nuxt4/package.json
  • playgrounds-ecosystem/nuxt5/package.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.

Walkthrough

The Nuxt 4 and Nuxt 5 playground package manifests no longer specify pnpm@12.14.0 in the packageManager field.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: Minimal · up to 8ee59

The playgrounds can use the root pnpm version without a known remaining merge risk.

Pre-merge checks: Passed 5
Check name Status Explanation
Description check Passed The description clearly explains the pnpm version mismatch and the removal of the Nuxt 4 and Nuxt 5 packageManager pins.
Title check Passed The title clearly and concisely states that the Nuxt 4 and 5 playgrounds will inherit the root pnpm version.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@antfu
antfu merged commit e727f2d into main Oct 27, 2026
10 checks passed
@antfu
antfu deleted the fix/ecosystem-playground-pnpm-pin branch October 27, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants